Diff for "DatetimeUsageGuide"

Not logged in - Log In / Register

Differences between revisions 2 and 3
Revision 2 as of 2009-07-24 13:24:31
Size: 6303
Comment:
Revision 3 as of 2021-08-09 17:12:42
Size: 5381
Editor: cjwatson
Comment: update for Storm and modern fmt adapters
Deletions are marked like this. Additions are marked like this.
Line 7: Line 7:
 * SQLObject wrappers for database tables, which act as an adapter between the above two  * Storm wrappers for database tables, which act as an adapter between the above two
Line 49: Line 49:
=== SQLObject === === Storm ===
Line 51: Line 51:
To wrap a timestamp database column, use the {{{canonical.database.datetimecol.UtcDateTimeCol}}} type. To wrap an interval database column, use the {{{sqlobject.IntervalCol}}} type: To wrap a timestamp database column, use the {{{storm.properties.DateTime}}} type. To wrap an interval database column, use the {{{storm.properties.TimeDelta}}} type:
Line 54: Line 54:
from sqlobject import IntervalCol
from canonical.database.sqlbase import SQLBase
from canonical.database.datetimecol import UtcDateTimeCol
import pytz
from storm.properties import (
    DateTime,
    TimeDelta,
    )
Line 58: Line 60:
class TableName(SQLBase):
    timestampcol = UtcDateTimeCol(dbname='timestampcol')
    intervalcol = IntervalCol(dbname='intervalcol')
from lp.services.database.stormbase import StormBase

class TableName(StormBase):
    timestamp = DateTime(name='timestamp', tzinfo=pytz.UTC)
    interval = TimeDelta(name='interval')
Line 62: Line 66:

The {{{UtcDateTimeCol}}} type differs from the standard SQLObject {{{DateTimeCol}}} in the following ways:
 1. when you read a value, a time zone aware {{{datetime}}} value will be returned rather than a naïve value.
 2. when you write a value, it will be converted to UTC first. This has the side effect of raising an exception if you attempt to write a naïve value to the database.

The {{{IntervalCol}}} type represents database interval values using the Python {{{timedelta}}} type.

Note that the standard {{{DatetimeCol}}} type should not be used for either timestamps or intervals. It does not correctly handle time zones, and is the wrong type to use for intervals.
Line 82: Line 77:
<span
  
tal:attributes="title context/datecreates/fmt:datetime"
  tal:content="context/datecreated/fmt:approximatedate">
 2005-10-18
<
/span>}}}
<tal:created
  replace="structure context/datecreated/fmt:approximatedatetitle" />}}}
Line 114: Line 106:
from canonical.database.constants import UTC_NOW from lp.services.database.constants import UTC_NOW
Line 119: Line 111:
(note that you won't be able to read the value as a Python {{{datetime}}} object until the {{{sync()}}} method for the SQLObject is called, or the transaction is committed). (note that you won't be able to read the value as a Python {{{datetime}}} object until the object is flushed to the database, or the transaction is committed).
Line 121: Line 113:
To store a time relative to the present time in a database column, we can make use of the fact that {{{UTC_NOW}}} is an "sql builder" type: To store a time relative to the present time in a database column, we can make use of the fact that {{{UTC_NOW}}} is an `SQL()` type:
Line 126: Line 118:
The database transaction time can be retrieved like so:
  {{{#!python
from canonical.database.sqlbase import cursor
cur = cursor()
cur.execute("SELECT CURRENT_TIMESTAMP AT TIME ZONE 'UTC';")
[database_now] = cur.fetchone()
}}}
The database transaction time can be retrieved using `lp.services.database.sqlbase.get_transaction_timestamp`.

Datetime Usage Guide

There are a number of places in Launchpad where datetime types are used. There are three main places where datetime types are represented:

  • Python code
  • in the database as table columns
  • Storm wrappers for database tables, which act as an adapter between the above two
  • TALES fmt:date, fmt:time and fmt:datetime formatters.

Furthermore, there are two main datetime types in use:

  • timestamps, which identify a particular point in time
  • time deltas, which identify an interval in time

Data Types

Python

We use the standard datetime module to represent time stamps and time deltas -- the datetime.datetime type for timestamps, and the datetime.timedelta type for time deltas.

To make matters a little bit more complicated, there are actually two types of datetime.datetime objects:

  1. naïve datetime objects

  2. timezone aware datetime objects

While both objects share the same Python type, they can not be compared with each other. Where possible, we use timezone aware datetime objects.

A timezone aware datetime can be created with the following code:

  •    1 import datetime
       2 import pytz
       3 
       4 UTC = pytz.timezone('UTC')
       5 dt = datetime.datetime(2005, 1, 1, 8, 0, 0, tzinfo=UTC)
    

The pytz.timezone() function can be used to retrieve tzinfo objects for any of the named Olsen time zones. A datetime value can be converted to another time zone as follows:

  •    1 perth_tz = pytz.timezone('Australia/Perth')
       2 perth_time = dt.astimezone(perth_tz)
    

PostgreSQL

In Postgres, the TIMESTAMP WITHOUT TIME ZONE should be used to represent timestamps, and INTERVAL should be used to represent time deltas. All timestamp columns in the database should store the time in UTC.

While Postgres has a TIMESTAMP WITH TIME ZONE type, it should not be used. The difference between the two column types is that the value of a TIMESTAMP WITH TIME ZONE column will be converted to local time when being read, and the reverse occurs when being written. It does not actually store a time zone with the timestamp.

Storm

To wrap a timestamp database column, use the storm.properties.DateTime type. To wrap an interval database column, use the storm.properties.TimeDelta type:

  •    1 import pytz
       2 from storm.properties import (
       3     DateTime,
       4     TimeDelta,
       5     )
       6 
       7 from lp.services.database.stormbase import StormBase
       8 
       9 class TableName(StormBase):
      10     timestamp = DateTime(name='timestamp', tzinfo=pytz.UTC)
      11     interval = TimeDelta(name='interval')
    

Page Templates

Inside page templates, use the following TALES formatters to present timestamp objects:

  • fmt:date

  • fmt:time

  • fmt:datetime

  • fmt:approximatedate

The preferred method of presenting datetime is:

  • <tal:created
      replace="structure context/datecreated/fmt:approximatedatetitle" />

When in doubt, use this presentation.

If the timestamp has a time zone attached, these formatters will convert the date to the user's local time before display.

For time interval objects, use the following formatters:

  • fmt:exactduration

  • fmt:approximateduration

Two Concepts of "Now"

When working with the database, there are two distinct concepts of "now" to work with:

  1. the time when the code is running (e.g. returned by datetime.now()).

  2. the database transaction time (when the transaction is committed, all the changes will appear to have happened atomically at that time).

Usually these two mean almost the same thing, but they will differ under the following conditions:

  • clock skew between the application server and database server (should not be a problem on our servers).
  • with long running transactions, the second "now" will be the time at the start of the transaction.

In cases where you are comparing timestamps, mixing the two concepts of "now" can result in race conditions. In most cases in Launchpad, the database transaction time is the correct one to use.

Database Transaction Time

Storing the current database transaction time in the database use the following syntax:

  •    1 from lp.services.database.constants import UTC_NOW
       2 
       3 person.datecreated = UTC_NOW
    

(note that you won't be able to read the value as a Python datetime object until the object is flushed to the database, or the transaction is committed).

To store a time relative to the present time in a database column, we can make use of the fact that UTC_NOW is an SQL() type:

  •    1 membership.dateexpires = UTC_NOW + datetime.timedelta(months=6)
    

The database transaction time can be retrieved using lp.services.database.sqlbase.get_transaction_timestamp.

Present Time

To create a Python datetime object that represents the present time, use the following code:

  •    1 import datetime
       2 import pytz
       3 
       4 UTC = pytz.timezone('UTC')
       5 dt = datetime.datetime.now(UTC)
    

Note that the datetime.utcnow() method should not be used -- it creates a naïve datetime value, which can not be compared against other values in Launchpad.

DatetimeUsageGuide (last edited 2021-08-09 17:12:42 by cjwatson)