Diff for "PreMergeReviews"

Not logged in - Log In / Register

Differences between revisions 3 and 4
Revision 3 as of 2009-07-21 12:18:21
Size: 4470
Editor: jsk
Comment: Changing the amusing phrase "implement any feature or bug" to "implement any feature or fix any bug". I'm sure nobody intends to implement bugs :)
Revision 4 as of 2010-01-21 10:48:49
Size: 4469
Editor: henninge
Deletions are marked like this. Additions are marked like this.
Line 30: Line 30:
== What are reviewers looking for ? == == What are reviewers looking for? ==

<<TableOfContents: execution failed [Too many arguments] (see also the log)>>


The Launchpad code has been placed under mandatory pre-merge review. Read this document carefully for a description of the review process and what it entails. we use Launchpad Code Merge Proposals to manage the queue of work.

What are Pre-Merge Reviews?

Pre-merge reviews are peer reviews of source code modifications. They are a great tool for ensuring quality of the resulting product, and also for communicating technique and style between team members. A good review process ensures that everybody learns at a much faster rate, and creates a valuable technical relationship between reviewer and coder.

Pre-Implementation Call

We encourage all developers to arrange pre-implementation design reviews with another developer, preferably by phone call. IRC can be used if a phone call is not possible, but voice contact is more desirable.

Pre-implementation calls should be used before starting to implement any feature or fix any bug. For more details on the work flow and what is expected from both callers and callees, see DesignPhoneCall.

Working with PreMergeReviews

For pre-merge reviews to be effective, however, small modifications to the development workflow are required. The main modification is, of course, requesting peer review of your code changes before merging your code into RocketFuel. The sections below go into the details of how this is best performed. There is a crib sheet for getting a branch merged on the WorkingWithReviews page.

Branch size limits

A limit of 800 lines per branch diff has been set as a maximum. If your branch grows above this limit you must negotiate with a reviewer to accept the oversized branch. Note that very large branches are not recommended for on-call reviews as they slow down the work of the reviewer who is trying interactively review a high volume of branches during the shift.

What are reviewers looking for?

Reviewers are checking both the design of your branch and the quality of the code in it. The best way to understand what a review is looking for is to read TipsForReviewers. (You can also use the CodeReviewChecklist cheat-sheet to do a self-review.)

If in doubt, use a branch

Any non-trivial changes for review must be on a branch. The goal is to make it easy to look at which changes have been made without spurious diffs, and without having to worry about RocketFuel changing from under your feet. A good rule of thumb is:

If what you're working on is complex enough that you'll likely be making several commits, you definitely need a branch.

You are responsible for your branch

The central rule that is used in the Launchpad review process is:

  • The coder is responsible for getting his branch through the review process

This means that you, as a coder, are reponsible for

  1. writing the code
  2. requesting review (use Launchpad Merge Proposals)
  3. finding a reviewer (ask an on-call reviewer on #launchpad-reviews, or arrange with another reviewer)
  4. dealing with review comments / requests (Reply to all queries)
  5. landing your change (You may land when the proposal is Approved)

The reviewer, conversely, is responsible only for two important things:

  • Reviewing requests in a timely manner, (respond to requests on #launchpad-reviews, ).
  • Participating in follow-up discussion once a review is sent.
  • Be clear about the changes you expect to see
  • Set the status of your review, and if you are the final reviewer, set the status of the merge proposal.

The reviewer is the obvious bottleneck in the process, and if you can make his life easier, please do. This includes making smaller changes, coordinating with other developers to order reviews to minimize conflicts, and reminding of forgotten branches periodically.

Requesting review

Before you request a review, you should make sure that make check_merge reports no errors after having first merged rocketfuel[1], as fixing any broken tests after a review might involve an unnecessary additional review which could have been avoided.

Dealing with reviews

A thorough guide to dealing with reviews and finally merging your changes is available at WorkingWithReviews.

See also

PreMergeReviews (last edited 2021-11-11 10:00:34 by cjwatson)