= ReviewerMeeting20081119 =

== summary ==

 * People should come prepared to discuss/lobby for their top 1-2 m-p bug at the next reviewer meeting. Include bug numbers.
 * al-maisan nominated as reviewer, looking for mentor
 * barry to work on patch avoiding circular imports

== log ==

{{{
Nov 19 10:00:13 <barry>	#startmeeting
Nov 19 10:00:14 <MootBot>	Meeting started at 09:00. The chair is barry.
Nov 19 10:00:14 <MootBot>	Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE]
Nov 19 10:00:29 <barry>	hello everyone and welcome to this week's ameu reviewer's meeting.  who's here today?
Nov 19 10:00:31 <rockstar>	me
Nov 19 10:00:42 *	abentley (n=abentley@bas1-toronto09-1279474851.dsl.bell.ca) has joined #launchpad-meeting
Nov 19 10:00:42 <mrevell>	me
Nov 19 10:00:45 *	flacoste (n=francis@canonical/launchpad/flacoste) has joined #launchpad-meeting
Nov 19 10:00:52 <abentley>	me
Nov 19 10:00:53 <adeuring>	me
Nov 19 10:00:55 <bigjools>	me
Nov 19 10:00:56 <allenap>	me, but only half (sprinting in Lexington)
Nov 19 10:00:59 <EdwinGrubbs>	me
Nov 19 10:01:09 <abentley>	allenap: m ?
Nov 19 10:01:36 <danilos>	me
Nov 19 10:01:44 <allenap>	abentley: This week it's e
Nov 19 10:01:56 <flacoste>	me
Nov 19 10:02:20 <mars>	me
Nov 19 10:02:36 <barry>	[TOPIC] agenda
Nov 19 10:02:37 <MootBot>	New Topic:  agenda
Nov 19 10:02:42 <barry>	i don't have much today...
Nov 19 10:02:50 <barry>	 * Roll call
Nov 19 10:02:50 <barry>	 * Agreement on statuses:
Nov 19 10:02:50 <barry>	   * needs-reply == needs-fixing
Nov 19 10:02:50 <barry>	   * merge-approved == approve
Nov 19 10:02:50 <barry>	   * merge-conditional == approve + comment
Nov 19 10:02:50 <barry>	 * If there's time, the old boring script
Nov 19 10:02:50 <barry>	   * Next meeting
Nov 19 10:02:50 <barry>	   * Action items
Nov 19 10:02:50 <barry>	   * Queue status
Nov 19 10:02:50 <barry>	   * Mentoring update
Nov 19 10:03:02 <barry>	[TOPIC]  * Agreement on statuses:
Nov 19 10:03:04 <MootBot>	New Topic:   * Agreement on statuses:
Nov 19 10:03:13 <BjornT>	me
Nov 19 10:03:15 <gmb>	me
Nov 19 10:03:38 <barry>	at the asiapac meeting, i explained what we'd agreed from last week on the mapping between our review status and m-p statuses
Nov 19 10:03:49 <barry>	everyone there agreed with our mapping
Nov 19 10:03:59 <barry>	so i guess that makes it official
Nov 19 10:04:13 <barry>	any comments or other thoughts?
Nov 19 10:04:28 <flacoste>	can you remind us of that mapping?
Nov 19 10:04:37 <danilos>	flacoste: it's up in the agenda
Nov 19 10:04:40 <danilos>	:)
Nov 19 10:04:44 <flacoste>	doh
Nov 19 10:05:01 <barry>	:)
Nov 19 10:06:05 <barry>	silence is assent :)
Nov 19 10:06:23 <barry>	that's all i have except for the boring stuff.  does anybody have anything not on the agenda?
Nov 19 10:06:52 <danilos>	yeah
Nov 19 10:07:13 <danilos>	I wonder about how do we see if there are branches waiting for review in merge-proposals?
Nov 19 10:07:13 <barry>	danilos: the floor is yours
Nov 19 10:07:33 <barry>	danilos: they mythical dashboard
Nov 19 10:07:41 <barry>	s/they/the/
Nov 19 10:07:41 <danilos>	I've tried digging that up, but was unable to find it once I cleared general queue yesterday
Nov 19 10:07:52 <danilos>	ok, so it's actually not there?
Nov 19 10:08:13 <danilos>	can we maybe agree to put branches in 'Mature' until it's there?
Nov 19 10:08:28 <danilos>	or some other status
Nov 19 10:08:30 <abentley>	danilos: Other that this: https://code.edge.launchpad.net/~launchpad-pqm/launchpad/devel/+merges ?
Nov 19 10:09:05 <danilos>	abentley: that doesn't show me only unassigned ones
Nov 19 10:09:26 <barry>	abentley: that's a good page.  i can already tell that the separate approve step doesn't work 'cause no one set it ;/
Nov 19 10:09:48 *	sinzui forgot to type me
Nov 19 10:09:50 <sinzui>	me
Nov 19 10:10:11 <abentley>	danilos: All of them will be assigned to Launchpad Developers by default.
Nov 19 10:11:41 <danilos>	abentley: ok, so the only missing bit is that we need to update merge proposal statuses to 'Approved', right?
Nov 19 10:12:09 <bac>	me
Nov 19 10:12:14 <danilos>	and, can we make this URL more visible? I tried getting something along those lines
Nov 19 10:12:18 <abentley>	danilos: Right.  When they're reviewed, and ready to be merged.
Nov 19 10:13:15 <abentley>	danilos: It's the "12 branches       proposed for merging into this one." link on https://code.edge.launchpad.net/~launchpad-pqm/launchpad/devel
Nov 19 10:13:24 <danilos>	abentley: ok, thanks
Nov 19 10:13:45 <barry>	anything else?
Nov 19 10:13:46 <danilos>	so, my suggestion would be to make reviewers set "Approved" as well
Nov 19 10:13:53 <danilos>	barry: nope, that's it from me
Nov 19 10:14:04 <barry>	danilos: +
Nov 19 10:14:06 <barry>	+
Nov 19 10:14:09 <abentley>	barry: How do I subscribe to the new wiki page?
Nov 19 10:14:10 <barry>	jeebus.  +1
Nov 19 10:14:29 <barry>	abentley: that's a very good question.  i tried to find it and couldn't
Nov 19 10:14:30 <bigjools>	you can't!  the price of progress ...
Nov 19 10:14:40 *	barry has a BIG LIST of issues with the new wiki
Nov 19 10:14:42 <abentley>	+1.  Thought that was already done.
Nov 19 10:15:04 <barry>	abentley: go to your profile page, scroll down to subscriptions and add .* to the list :)
Nov 19 10:15:25 <rockstar>	abentley: there's a bug for it, we talked about it yesterday.
Nov 19 10:16:02 <barry>	rockstar: a bug for wiki subscription?
Nov 19 10:17:55 <barry>	someone wake rockstar :)
Nov 19 10:17:59 <barry>	anyway...
Nov 19 10:18:17 *	allenap has quit ("rebooting")
Nov 19 10:18:23 <barry>	if there's nothing else, i just want to run through the outstanding action items from like, last decade
Nov 19 10:18:27 <BjornT>	barry: i have a small agenda item as well (or rather a question)
Nov 19 10:18:37 <barry>	BjornT: cool, go ahead
Nov 19 10:19:15 <BjornT>	when are we going to evaluate how the merge proposals are going, and which issues are the most important (for the LP team as a whole) to fix?
Nov 19 10:20:17 <barry>	BjornT: great question.  i'm inclined to say let's do the evaluation at the beginning of '09.  your thoughts?
Nov 19 10:20:45 <BjornT>	barry: well, i was hoping sooner, so that we could get the most important fixes in the next milestone :)
Nov 19 10:21:29 <barry>	BjornT: :)
Nov 19 10:21:47 *	allenap (n=gavin@bismuth.canonical.com) has joined #launchpad-meeting
Nov 19 10:21:55 <barry>	BjornT: i'm okay with that.  what about doing that for the next round of reviewer meetings?
Nov 19 10:22:21 <BjornT>	barry: sure
Nov 19 10:22:26 <barry>	iow, people should come prepared to discuss/lobby for their top m-p bugs
Nov 19 10:22:48 <bigjools>	diffs plz
Nov 19 10:22:57 <barry>	we can spend next week's meeting prioritizing them for us
Nov 19 10:23:12 <barry>	bigjools: bug numbers plz :)
Nov 19 10:23:18 <bigjools>	haha :)
Nov 19 10:23:34 <BjornT>	barry: maybe we should tell everyone to pick their 1-2 top bugs, in an attempt to limit the discussions?
Nov 19 10:23:45 <barry>	BjornT: yes, good idea
Nov 19 10:24:07 <abentley>	barry: We can decide here what lp reviewers consider high priority.  Please don't expect the code team to adopt those priorities verbatim.
Nov 19 10:24:20 <flacoste>	abentley: that's for sure
Nov 19 10:24:22 <barry>	[ACTION] everyone come to next week's meeting with your top 1-2 merge-proposal bug numbers
Nov 19 10:24:23 <MootBot>	ACTION received:  everyone come to next week's meeting with your top 1-2 merge-proposal bug numbers
Nov 19 10:24:30 <barry>	abentley: right
Nov 19 10:24:56 <abentley>	barry: Or alternatively, we could have a meeting where thumper was involved.
Nov 19 10:25:19 <barry>	abentley: we should do that, but only after we've agreed among ourselves
Nov 19 10:25:20 <abentley>	And then the outcome might be clearer.
Nov 19 10:25:42 <barry>	abentley: and remember i have asiapac meetings with thumper and co on monday nights (i know you know that :)
Nov 19 10:25:51 <barry>	well, /my/ monday nights
Nov 19 10:26:06 <BjornT>	abentley: agreed, the priorities we come up with here only serves for guidelines. i don't think thumper needs to be in this meeting.
Nov 19 10:26:17 <abentley>	Okay.
Nov 19 10:26:49 <barry>	any other topics not on the agenda?
Nov 19 10:27:27 *	bigjools raises hand
Nov 19 10:27:37 <bigjools>	can I nominate a new reviewer?
Nov 19 10:27:46 <barry>	bigjools: of course!
Nov 19 10:27:54 <bigjools>	good - Muharem wants to start.
Nov 19 10:28:14 <bigjools>	he's looking for a mentor right now
Nov 19 10:28:41 <bigjools>	OAO
Nov 19 10:29:10 <barry>	bigjools: +1. let me know if he can't round someone up
Nov 19 10:29:18 <bigjools>	copy that
Nov 19 10:29:46 <barry>	anything else?
Nov 19 10:30:00 <barry>	5...4...3...2...1
Nov 19 10:30:13 <barry>	[TOPIC] action items
Nov 19 10:30:15 <MootBot>	New Topic:  action items
Nov 19 10:30:27 <barry>	please tell me if we should continue these or just forget they ever happened
Nov 19 10:30:33 <barry>	 * flacoste and foundations to look into techniques for eliminating back-patching of schema types (avoiding circular imports)
Nov 19 10:30:46 *	bigjools would love that --^
Nov 19 10:30:58 *	barry too, and he doesn't think it's that hard
Nov 19 10:30:59 <flacoste>	hmm, yeah, i forgot about that
Nov 19 10:31:13 <flacoste>	barry, patch is welcome ;-)
Nov 19 10:31:28 <barry>	flacoste: ah, a challenge! :)
Nov 19 10:31:29 <bigjools>	wow, OSS fever :)
Nov 19 10:31:46 <barry>	flacoste: sounds like the perfect thing to do while on hold waiting for your isp to un-fsck you
Nov 19 10:32:10 <barry>	so we'll continue that one
Nov 19 10:32:15 <barry>	 * rockstar to take discussion of adding launchpadlib tests for exposed api to ml
Nov 19 10:32:51 *	barry thinks rockstar fell asleep again :)
Nov 19 10:32:57 <barry>	 * abentley to investigate current code coverage tools for lp tests
Nov 19 10:33:27 <rockstar>	barry, well, we discussed it at the Epic.
Nov 19 10:33:29 <abentley>	Current tools don't do what I want.
Nov 19 10:34:18 <barry>	rockstar: good.  i will remove it from the agenda! thanks
Nov 19 10:34:34 <barry>	abentley: cool, you've investigated so i can take it off the agenda :)
Nov 19 10:35:00 <flacoste>	rockstar: could you file a bug about allowing launchpadlib to speak directly to the publisher for testing purpose?
Nov 19 10:35:10 <rockstar>	flacoste, sure.
Nov 19 10:35:18 <abentley>	What I want is a way to know whether a given test command exercises all the new code in a patch.
Nov 19 10:35:23 <flacoste>	rockstar: that's the main blocker to allow this
Nov 19 10:35:56 <rockstar>	Okay.
Nov 19 10:36:45 <barry>	i think that's it.  if there are no objections we can end early today
Nov 19 10:36:48 <barry>	5
Nov 19 10:37:12 <barry>	4
Nov 19 10:37:26 <barry>	3
Nov 19 10:37:32 <barry>	2
Nov 19 10:37:36 <barry>	1
Nov 19 10:37:39 <barry>	#endmeeting
}}}