= ReviewerMeeting20090513 =

== summary ==

 * watch out for moved `LaunchpadObjectFactory`, `login` and `logout`.  thumper moved the former to `lp.testing.factory` and the latter to `lp.testing`, but left shims in place due to import problems.  urge developers to remove the need for the shims.

== logs ==

=== AMEU ===

{{{
May 13 10:00:54 <barry>	#startmeeting
May 13 10:00:55 <MootBot>	Meeting started at 09:00. The chair is barry.
May 13 10:00:55 <MootBot>	Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE]
May 13 10:00:59 <gary_poster>	me
May 13 10:01:09 <barry>	hello everyone and welcome to this week's ameu reviewer's meeting.  who's here today?
May 13 10:01:09 <gary_poster>	(first post, first post!)
May 13 10:01:16 <gary_poster>	uh, me
May 13 10:01:17 <danilos>	me
May 13 10:01:19 <danilos>	gary_poster: :)
May 13 10:01:24 <adeuring>	me
May 13 10:01:25 <noodles775>	me too
May 13 10:01:26 <henninge>	me!!! ;)
May 13 10:01:32 *	Ursinha (n=ursula@canonical/launchpad/ursinha) has joined #launchpad-meeting
May 13 10:01:34 <bigjools>	me
May 13 10:01:34 <gmb>	Mi.
May 13 10:01:45 <mars>	me
May 13 10:01:46 <henninge>	gmb: It's Mii
May 13 10:01:48 <bac>	me
May 13 10:01:53 <henninge>	as in Wii
May 13 10:02:02 <intellectronica>	me
May 13 10:02:08 <gmb>	henninge: I was banging on the keyboard like a monkey. Be thankful you got what you did.
May 13 10:02:08 <salgado>	me
May 13 10:02:18 <gary_poster>	lol
May 13 10:02:51 <barry>	allenap: ping
May 13 10:03:00 <allenap>	me
May 13 10:03:19 <barry>	BjornT, cprov, EdwinGrubbs ping
May 13 10:03:26 <cprov>	me
May 13 10:03:39 <BjornT>	me
May 13 10:03:43 <flacoste>	me
May 13 10:04:01 <barry>	rockstar: sinzui ping
May 13 10:04:08 <barry>	[TOPIC] == Agenda ==
May 13 10:04:08 <barry>	 * Roll call
May 13 10:04:08 <barry>	 * Action items
May 13 10:04:08 <barry>	 * Mentoring update
May 13 10:04:08 <barry>	 * Peanut gallery (anything not on the agenda)
May 13 10:04:09 <MootBot>	New Topic:  == Agenda ==
May 13 10:04:16 <sinzui>	me
May 13 10:04:24 <barry>	[TOPIC]  * Action items
May 13 10:04:25 <MootBot>	New Topic:   * Action items
May 13 10:04:33 <barry>	 * gary_poster to take importfascist and rSP() discussion to ml
May 13 10:04:40 <gary_poster>	no, sorry
May 13 10:04:53 <barry>	gary_poster: next time? :)
May 13 10:05:10 <gary_poster>	I hope so :-)  Looking for that info now
May 13 10:05:18 <barry>	cool, thx
May 13 10:05:19 <barry>	 * flacoste to work on API reviewer cheat sheet
May 13 10:05:26 *	flacoste whistles
May 13 10:05:46 <barry>	:)
May 13 10:05:55 <barry>	[TOPIC]  * Mentoring update
May 13 10:05:56 <MootBot>	New Topic:   * Mentoring update
May 13 10:05:59 <bigjools>	whistling while you work?
May 13 10:06:02 <sinzui>	It's not exported until there is  a test
May 13 10:06:28 *	sinzui found a field that was not really exported, and there was no test to verify it was broken
May 13 10:06:31 <barry>	any updates, problems, issues, questions, comments from mentats or mentors?
May 13 10:06:42 <henninge>	I'm fine .
May 13 10:06:52 <noodles775>	not really... I'm enjoy the learning process so far :)
May 13 10:07:32 <barry>	great!
May 13 10:07:48 <barry>	thanks mentors
May 13 10:07:55 <barry>	[TOPIC]  * Peanut gallery (anything not on the agenda)
May 13 10:07:55 <MootBot>	New Topic:   * Peanut gallery (anything not on the agenda)
May 13 10:08:06 <barry>	that's all i have for today, do you all have anything?
May 13 10:09:07 <barry>	i guess not
May 13 10:09:16 <barry>	looks like maybe we're done in record time?
May 13 10:09:24 <henninge>	Y nodd
May 13 10:09:31 <henninge>	;)
May 13 10:09:33 <barry>	5
May 13 10:09:36 <barry>	4
May 13 10:09:40 <barry>	3
May 13 10:09:44 <barry>	2
May 13 10:09:46 <barry>	1
May 13 10:09:50 <barry>	#endmeeting
}}}

=== AsiaPac ==

{{{
May 13 18:32:32 <barry>	#startmeeting
May 13 18:32:32 <jml>	hi?
May 13 18:32:32 <MootBot>	Meeting started at 17:32. The chair is barry.
May 13 18:32:32 <MootBot>	Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE]
May 13 18:32:37 <jml>	wasn't it in +0.5?
May 13 18:32:53 <barry>	i think we're on the half hour
May 13 18:33:06 <barry>	AsiaPac Wednesday 13-May-2009 2230 UTC - 2315 UTC
May 13 18:33:20 <barry>	thumper, mwhudson are you here?
May 13 18:33:23 <mwhudson>	yeah
May 13 18:33:46 <thumper>	yeah
May 13 18:33:49 <barry>	i really have almost nothing, so i'll dispense with the formalities and throw it open to you guys
May 13 18:34:00 <mwhudson>	hey, this cycle is really short
May 13 18:34:16 <barry>	mwhudson: indeed, but it's been my most productive one in months :)
May 13 18:34:44 <barry>	thumper: you had an item?
May 13 18:34:47 <thumper>	yes
May 13 18:35:00 <thumper>	I've moved the LaunchpadObjectFactory to live in lp.testing.factory
May 13 18:35:09 <thumper>	and login, logout et al lp.testing
May 13 18:35:15 <thumper>	reviews should check this now
May 13 18:35:17 <jml>	phone, sorry
May 13 18:35:33 <thumper>	there are compability shims in canonical.launchpad.testing
May 13 18:35:37 <thumper>	that I'd like to see go
May 13 18:35:41 <barry>	thumper: cool, thanks for doing the rename.  
May 13 18:35:45 <thumper>	but there were like a million places in the code
May 13 18:35:48 <thumper>	so I didn't do that
May 13 18:35:55 <thumper>	and my awk foo isn't that good
May 13 18:36:06 <barry>	thumper: i know a great language that you could write it in
May 13 18:36:14 <thumper>	I did consider it
May 13 18:36:22 <thumper>	but it isn't a simple 1 -> 1 move
May 13 18:36:35 <barry>	thumper: actually (seriously) check with sinzui.  he may have all the basic pieces
May 13 18:36:42 <thumper>	not enough
May 13 18:36:54 <thumper>	I used the rename-module script for most of it
May 13 18:37:01 <thumper>	but due to circular import crap
May 13 18:37:09 <barry>	thumper: oh, and doctests /should/ be easy since none of them should explicitly import it
May 13 18:37:13 <thumper>	I couldn't import the factory into lp.testing.__init__
May 13 18:37:14 <sinzui>	lp-dev-utils/migrater/rename_module path_to_old path_to_new
May 13 18:37:23 <thumper>	barry: they are done
May 13 18:37:28 <thumper>	barry: I fixed the globs
May 13 18:37:34 <barry>	thumper: cool
May 13 18:37:53 <barry>	thumper: why does lp.testing.__init__ need it?
May 13 18:38:00 <thumper>	barry: it doesn't
May 13 18:38:05 <thumper>	but the old import did that
May 13 18:38:08 <sinzui>	thumper: do you want to do a find and replace of an import path across the whole tree?
May 13 18:38:13 <thumper>	so you could get the factory from canonical.launchpad.testing
May 13 18:38:17 <barry>	oh i see, and call sites used the old import
May 13 18:38:22 <thumper>	now you need to get it from lp.testing.factory
May 13 18:38:32 <thumper>	but login et al can come from lp.testing
May 13 18:38:47 <thumper>	sinzui: for a single class, yes
May 13 18:39:08 <thumper>	sinzui: although you could do it if you like :)
May 13 18:39:20 <thumper>	also, much mail stuff moved into lp.services.mail
May 13 18:39:35 <thumper>	so
May 13 18:39:36 <thumper>	sendmail
May 13 18:39:41 <thumper>	signed_message
May 13 18:39:44 <thumper>	some others
May 13 18:39:47 <thumper>	more needs to move
May 13 18:39:49 <thumper>	but I did some
May 13 18:40:05 <sinzui>	lp-dev-utils/migrater/find.py [-s 'new.path'] . . 'python_re_pattern'
May 13 18:40:20 <sinzui>	thumper: send me the module old and new path
May 13 18:40:36 <barry>	thumper: can you add deprecation warnings to the shims?  i think that will fail the tests though
May 13 18:40:57 <thumper>	sinzui: LaunchpadObjectFactory from canonical.launchpad.testing to lp.testing.factory
May 13 18:41:07 <thumper>	barry: that was all
May 13 18:41:17 <thumper>	barry: that and poking others to continue moving stuff
May 13 18:41:32 <thumper>	:(
May 13 18:41:35 <thumper>	plasma just died
May 13 18:41:48 <barry>	thumper: cool.  i suggest an email to the ml to motivate devs to do drive bys
May 13 18:42:08 <thumper>	relentless poking at all hands should suffice
May 13 18:42:18 <barry>	cool, thanks
May 13 18:42:23 <barry>	anything else from you guys?
May 13 18:42:31 <thumper>	not from me
May 13 18:42:37 <barry>	jml, mwhudson ?
May 13 18:43:05 <barry>	4
May 13 18:43:09 <barry>	3
May 13 18:43:12 <mwhudson>	i'm moving canonical.codehosting to lp.codehosting\
May 13 18:43:16 <mwhudson>	noone else should care though
May 13 18:43:22 <barry>	mwhudson: +1
May 13 18:43:34 <barry>	5
May 13 18:43:39 <barry>	4
May 13 18:43:42 <barry>	3
May 13 18:43:46 <barry>	2
May 13 18:43:48 <barry>	1
May 13 18:43:51 <barry>	#endmeeting
}}}