Diff for "Patches"

Not logged in - Log In / Register
Differences between revisions 8 and 9
⇤ ← Revision 8 as of 2009-08-03 22:06:11 →
Size: 2383
Editor: kfogel
Comment: Simpler name; also, this page discusses more than just submission.
← Revision 9 as of 2009-08-05 14:24:24 → ⇥
Size: 27
Editor: kfogel
Comment:
Deletions are marked like this. Additions are marked like this.
Line 1: Line 1:
## page was renamed from PatchSubmission
#format wiki
#language en
#pragma section-numbers off

= Submitting a Patch to Launchpad =

This page covers the process of getting a code change into Launchpad. You should already [[Getting|have the Launchpad sources]], be able to [[Running|build and run]] Launchpad, and be familiar with the [[StyleGuides|coding style guidelines]].

 1. Before making your change, it's a good idea to talk about it first to a Launchpad developer. The easiest way there is to ask the person listed as the on-call reviewer (OCR) in the [[irc://irc.freenode.net/launchpad-reviews|#launchpad-reviews]] IRC channel on `irc.freenode.net`. That "pre-implementation chat" will make sure that you have all things covered. If your proposal involves UI changes, you might even want to make screenshots or a [[ScreenCasts|screencast]].
 1. Make sure your change is about one single thing (say, a specific bugfix), and that all the revisions for it are committed on your Bazaar branch.
 1. Push the branch up to your Launchpad user account: '''{{{bzr push my_bugfix123_branch lp:~my_username/launchpad/bugfix123}}}'''
 1. [[Testing|Run tests]] on your branch. If the tests don't pass, go back to hacking, commit new changes, re-push, and re-test. Repeat until the branch passes.
 1. Please send in your [[ContributorAgreement|contributor agreement form]] now (it's an easy email process). We can't accept the change without a contributor agreement.
 1. Propose your branch for merging, by going to https://code.launchpad.net/~my_username/launchpad/bugfix123 and click on '''Propose for merging into another branch'''. (The branch to merge into is `lp:~launchpad-pqm/launchpad/devel`.) Fill in the field for requested reviewer with the name of the reviewer you found, and follow the guidelines for writing the [[CoverLetters|merge cover letter]].
 1. Find someone to review the branch. Usually, this would be the Launchpad developer with whom you had your "pre-implementation" chat about the change. If he or she is not available, you can ask in [[irc://irc.freenode.net/launchpad-reviews|#launchpad-reviews]] or [[irc://irc.freenode.net/launchpad-dev|#launchpad-dev]]. See the [[Reviews|Code Review]] page.
 1. Once the reviewer approves the change, they'll take care of merging your changes (that's until we work out an automated process).		 #redirect PatchSubmission

Patches (last edited 2009-08-05 14:24:24 by kfogel)