Diff for "PythonMigrationStatus"

Not logged in - Log In / Register
Differences between revisions 166 and 167
⇤ ← Revision 166 as of 2010-04-15 12:45:52 →
Size: 7006
Editor: wgrant
Comment: Most branches have been merged.
← Revision 167 as of 2010-04-15 19:37:12 → ⇥
Size: 6717
Editor: maxb
Comment:
Deletions are marked like this. Additions are marked like this.
Line 35: Line 35:
 * Have a locally patched sourcecode/pygpgme: {{{
--- src/pygpgme-context.c 2008-10-16 07:44:55 +0000
+++ src/pygpgme-context.c 2010-02-19 01:48:46 +0000
@@ -92,6 +92,8 @@
         return -1;
     }
 
+ gpgme_check_version(NULL);
+
     if (pygpgme_check_error(gpgme_new(&self->ctx)))
         return -1;
 

}}}
 * Do '''not''' have python-tdb installed, which otherwise causes bzr-hg and bzr-git to behave in ways the tests do not expect.
Line 52: Line 37:
  * lp:~maxb/launchpad/use-pygpgme-r49
 * Do '''not''' have python-tdb installed, which otherwise causes bzr-hg and bzr-git to behave in ways the tests do not expect.

Moving to newer Python versions

Contents

  1. Moving to newer Python versions
    1. Branches
    2. Issues that need revisiting
    3. Setup caveats
    4. Known test failures and notes thereon
      1. BaseLayer: OK (281 tests)
      2. MemcachedLayer: OK (8 tests)
      3. LibrarianLayer: OK (9 tests)
      4. DatabaseLayer: OK (46 tests)
      5. LaunchpadLayer: OK (24 tests)
      6. ZopelessLayer: OK (20 tests)
      7. LaunchpadScriptLayer: OK (85 tests)
      8. LaunchpadZopelessLayer
      9. FunctionalLayer: OK (174 tests)
      10. LaunchpadFunctionalLayer
      11. AppServerLayer: OK (143 tests)
      12. DatabaseFunctionalLayer: OK (4467 tests)
      13. GoogleLaunchpadFunctionalLayer: OK (72 tests)
      14. PageTestLayer: OK (6335 tests)
      15. TwistedLayer: OK (235 tests)
      16. TwistedLaunchpadZopelessLayer: OK (16 tests)
      17. TwistedAppServerLayer: OK (9 tests)
      18. ZopelessAppServerLayer
      19. ZopelessDatabaseLayer: OK (259 tests)
      20. BugsWindmillLayer: OK (13 tests)
      21. CodeWindmillLayer: OK (12 tests)
      22. ForeignBranchPluginLayer: OK (61 tests)
      23. SSHServerLayer: OK (46 tests)
      24. RegistryWindmillLayer: OK (17 tests)
      25. SoyuzWindmillLayer: OK (2 tests)
      26. TestZopeTestInSubProcessLayer: OK (1 test)
      27. TranslationsWindmillLayer: OK (7 tests)
      28. UnitTests: OK
      29. Shipit
      30. MailmanLayer: OK

With Lucid fast approaching, efforts to actually migrate Launchpad to Python 2.6 are getting under way.

Relevant tagged bugs: https://bugs.launchpad.net/launchpad-foundations/+bugs?field.tag=python-upgrade

Branches

Issues that need revisiting

  • The failure when setting up the GoogleServiceLayer seems to be a consequence of the server answering with a errno.ECONNABORTED when it's not yet ready, so salgado has just changed the wait_for_service function to treat that error the same way it does for errno.ECONNREFUSED.

  • The test hang is because of the change done on bug 349316, so salgado has just commented out that addCleanup() line for now, to see if we can get a full test run.

  • A multitude of modules of modules (sha, md5, sets, ...) are deprecated in Python 2.6, and many tests would fail merely because of unexpected DeprecationWarnings, so we've had to jump through multiple hoops all over the place to suppress these. Ultimately we need a plan for removing these suppressions, because we want to know about deprecation long-term.

Setup caveats

  • The extension modules in your sourcecode directory will have been built for Python 2.5 and these will break for your 2.6 branch. The simple thing to do is to move your old sourcecode aside and run utilities/rocketfuel-get to get it again with Python 2.6. A more complex but useful thing to do to manage sourcecode directories for multiple python versions is: 

    cd ~/launchpad/lp-sourcedeps
mkdir 2.6
cd 2.6
ln -s ../download-cache
ln -s ../eggs
mkdir sourcecode
cd sourcecode
for i in ../../sourcecode/*; do bzr checkout --lightweight "$i"; done

    and now point utilities/link-external-sourcecode to ../../lp-sourcedeps/2.6 - if you do that you'll need to be aware that rocketfuel-get won't know about it, and your extra directories will require occasional manual updating.

Known test failures and notes thereon

These results assume you:

  • Use the lp:~launchpad-committers/launchpad/python2.6 branch
  • Have the following not-yet-landed branches merged:
    • lp:~wgrant/launchpad/emailauthentication.txt-2.6-fix
    • lp:~maxb/launchpad/use-pygpgme-r49

  • Do not have python-tdb installed, which otherwise causes bzr-hg and bzr-git to behave in ways the tests do not expect.

BaseLayer: OK (281 tests)

MemcachedLayer: OK (8 tests)

LibrarianLayer: OK (9 tests)

DatabaseLayer: OK (46 tests)

LaunchpadLayer: OK (24 tests)

ZopelessLayer: OK (20 tests)

LaunchpadScriptLayer: OK (85 tests)

LaunchpadZopelessLayer

  • test_bug_496988 (lp.bugs.scripts.tests.test_checkwatches.TestCheckwatchesWithSyncableGnomeProducts) 

    Traceback (most recent call last):
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
  File "/home/maxb/launchpad/lp-sourcedeps/eggs/testtools-0.9.2-py2.6.egg/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/home/maxb/launchpad/lp-sourcedeps/eggs/testtools-0.9.2-py2.6.egg/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/home/maxb/launchpad/lp-branches/real-python-2.6/lib/lp/bugs/scripts/tests/test_checkwatches.py", line 109, in test_bug_496988
    gnome_bugzilla, [bug_watch_1, bug_watch_2])
  File "/home/maxb/launchpad/lp-branches/real-python-2.6/lib/lp/bugs/scripts/checkwatches/updater.py", line 522, in _getExternalBugTrackersAndWatches
    remote_bug_ids))
  File "/home/maxb/launchpad/lp-branches/real-python-2.6/lib/lp/bugs/externalbugtracker/bugzilla.py", line 617, in getProductsForRemoteBugs
    self.initializeRemoteBugDB(bug_ids)
  File "/home/maxb/launchpad/lp-branches/real-python-2.6/lib/lp/bugs/externalbugtracker/isolation.py", line 64, in wrapper
    return func(*args, **kwargs)
  File "/home/maxb/launchpad/lp-branches/real-python-2.6/lib/lp/bugs/externalbugtracker/bugzilla.py", line 568, in initializeRemoteBugDB
    'permissive': True,
  File "/usr/lib/python2.6/xmlrpclib.py", line 1199, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib/python2.6/xmlrpclib.py", line 1489, in __request
    verbose=self.__verbose
  File "/home/maxb/launchpad/lp-branches/real-python-2.6/lib/lp/bugs/externalbugtracker/xmlrpc.py", line 98, in request
    response = self._parse_response(self.opener.open(request), None)
  File "/usr/lib/python2.6/xmlrpclib.py", line 1392, in _parse_response
    return u.close()
  File "/usr/lib/python2.6/xmlrpclib.py", line 838, in close
    raise Fault(**self._stack[0])
Fault: <Fault Client: "Content-Type must be 'text/xml,' 'multipart/*,' or 'application/dime' instead of 'application/x-www-form-urlencoded'">
------------

FunctionalLayer: OK (174 tests)

LaunchpadFunctionalLayer

  • valid_absolute_url (canonical.launchpad.validators.url) -- Python 2.6's urlparse disregards the uses_netloc list when parsing urls and treats anything beginning with // as netloc based. This makes maxb and wgrant say WTF!?! The untested valid_absolute_url DB constraint is also affected!

AppServerLayer: OK (143 tests)

DatabaseFunctionalLayer: OK (4467 tests)

GoogleLaunchpadFunctionalLayer: OK (72 tests)

PageTestLayer: OK (6335 tests)

TwistedLayer: OK (235 tests)

TwistedLaunchpadZopelessLayer: OK (16 tests)

TwistedAppServerLayer: OK (9 tests)

ZopelessAppServerLayer

  • test_hosted_branch_stacked_on_mirrored_branch (lp.codehosting.puller.tests.test_acceptance.TestBranchPuller): LayerIsolationError: Test left new live threads: [<Thread(Thread-3, started daemon 47618947405584)>]

    • This is because of the join() that salgado commented out in this branch, since it hangs. mwhudson has some ideas on resolving the hang.

ZopelessDatabaseLayer: OK (259 tests)

BugsWindmillLayer: OK (13 tests)

CodeWindmillLayer: OK (12 tests)

ForeignBranchPluginLayer: OK (61 tests)

SSHServerLayer: OK (46 tests)

RegistryWindmillLayer: OK (17 tests)

SoyuzWindmillLayer: OK (2 tests)

TestZopeTestInSubProcessLayer: OK (1 test)

TranslationsWindmillLayer: OK (7 tests)

UnitTests: OK

Shipit

Might be ok now, I've fixed the errors that were listed here, but I don't have access to shipit --maxb.

MailmanLayer: OK