launchpad development
ReviewerMeeting20090304
summary
- all OCR reviewers are encouraged to review javascript
- al-maisan graduates
- noodles joins us as a javascript reviewer now, full mentat next cycle
log
Mar 04 10:00:43 <barry> #startmeeting Mar 04 10:00:44 <MootBot> Meeting started at 09:00. The chair is barry. Mar 04 10:00:44 <MootBot> Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] Mar 04 10:00:56 <barry> hello everyone and welcome to this week's ameu reviewers meeting. who's here today? Mar 04 10:00:57 <gmb> me Mar 04 10:01:02 <intellectronica> me Mar 04 10:01:03 <flacoste> me (at sprint - so half here) Mar 04 10:01:03 <adeuring> me Mar 04 10:01:06 <sinzui> me Mar 04 10:01:09 <noodles775> and me Mar 04 10:01:40 <cprov> me Mar 04 10:01:41 <BjornT> me Mar 04 10:01:42 <barry> welcome noodles775 ! Mar 04 10:01:49 * noodles775 grins Mar 04 10:02:05 <allenap> me Mar 04 10:02:39 <barry> bac: ping Mar 04 10:02:47 <bac> me Mar 04 10:02:59 <barry> danilos: ping Mar 04 10:03:03 <barry> EdwinGrubbs: ping Mar 04 10:03:16 <barry> mars: ping Mar 04 10:03:25 <barry> rockstar: ping Mar 04 10:03:34 <barry> salgado: ping Mar 04 10:03:44 <salgado> me Mar 04 10:03:46 <barry> [TOPIC] agenda Mar 04 10:03:47 <MootBot> New Topic: agenda Mar 04 10:03:58 <barry> pretty light day today! Mar 04 10:04:00 <barry> * Roll call Mar 04 10:04:00 <barry> * Peanut gallery (anything not on the agenda) Mar 04 10:04:00 <barry> * Mentoring update Mar 04 10:04:00 <barry> * al-maisan graduates Mar 04 10:04:00 <barry> * noodles to start js reviews this cycle, official mentat status next cycle Mar 04 10:04:00 <barry> * Action items Mar 04 10:04:21 <barry> [TOPIC] peanut gallery Mar 04 10:04:22 <MootBot> New Topic: peanut gallery Mar 04 10:04:33 <mars> me Mar 04 10:04:41 <barry> let's start off with this: does anyone have anything reviewish that they'd like to bring up? Mar 04 10:05:58 <barry> wow, nothing? Mar 04 10:06:23 <sinzui> js reviews Mar 04 10:06:39 <sinzui> can be difficult to organise when all the reviewers are sprinting Mar 04 10:07:10 <barry> mars: do we have a plan for mentoring more js reviewers? Mar 04 10:07:19 <sinzui> Do we want to consider a plan to train up js reviewers? Mar 04 10:07:32 <EdwinGrubbs> me Mar 04 10:07:33 <mars> barry, anyone can pick up a JS review, if they are comfortable doing so Mar 04 10:07:34 <intellectronica> ideally everyone should be able to review js Mar 04 10:08:12 <barry> sure, i'm just wondering if we need a mentoring program for those (like me) who feel less comfortable reviewing js. Mar 04 10:08:14 <adeuring> frankly, I think i need much more experience writing JS code before I would feel able to review JS code Mar 04 10:08:18 <mars> sinzui can't review his own JS code, but he can ask the OCR if they are comfortable doing so Mar 04 10:08:24 <mars> :) Mar 04 10:08:50 <mars> hmm Mar 04 10:09:36 <mars> the OCR/reviewer thing is the best we have for now - it spreads the knowledge pretty wide Mar 04 10:09:56 <mars> without having formal JS-Review training for all the other reviewers Mar 04 10:10:16 <barry> mars: i guess we just need backups then for stuff we're less experienced with? Mar 04 10:10:32 <sinzui> mars: Do we have updated standards and cheatsheet of common JS problems? Mar 04 10:10:44 <mars> barry, well, we do have 8 people who can review JS code Mar 04 10:10:55 <mars> sinzui, that's on my list to write today Mar 04 10:11:09 * sinzui is thinking of the rule that zope3 does not make css3 valid ids, so Y.get() fails. Mar 04 10:11:20 <intellectronica> barry: in a way, reviewing is a great way to build confidence, because you _have_ to understand what the code does and why it's written the way it is, and you _should_ ask if you don't :) Mar 04 10:11:20 <barry> mars: i actually like the idea of throwing people into the deep end, getting the ocr to review the js, but with an experienced js'er reviewing the review Mar 04 10:11:25 <mars> sinzui, :) Mar 04 10:11:48 <barry> intellectronica: yep :) Mar 04 10:12:14 <mars> barry, if you were at the sprint, you may have rethought that... Mar 04 10:12:22 <barry> lol Mar 04 10:12:34 <mars> the deep end for browser scripting is... deep Mar 04 10:12:36 <mars> with sharks Mar 04 10:12:44 <cprov> :) Mar 04 10:13:00 <barry> mars: foundations will make it all better, right? Mar 04 10:13:05 <mars> that's why I feel it's best suited to a "volunteer" program Mar 04 10:13:19 <barry> mars: or are you fitting laser helmets right now? Mar 04 10:13:23 <mars> barry, we're working on it - tools should help Mar 04 10:13:52 <mars> barry, yes, tools will help Mar 04 10:14:16 <mars> in a few cycles we should be to the point where the reviewer can just trust the tests Mar 04 10:14:37 <mars> but we're not there yet Mar 04 10:14:40 <barry> mars: i think coding guidelines will help a lot, even if they're incomplete Mar 04 10:14:49 <barry> mars: something a reviewer can read and point to Mar 04 10:14:51 <mars> agreed Mar 04 10:14:58 <barry> mars: that we fill up as questions arise Mar 04 10:15:21 <barry> mars: so i guess the recommendation is: ocr should try to review, and ask if you're not sure Mar 04 10:15:37 <mars> barry, true - the JS review then becomes more of a style and conformance review, but it still has value Mar 04 10:15:47 <mars> also agreed Mar 04 10:15:59 <barry> mars: i think that's the best way to start, since those are easier to get a handle on Mar 04 10:16:09 <barry> oh, i also want to point out that mars updated https://dev.launchpad.net/ReviewerSchedule Mar 04 10:16:25 <barry> this now includes a "specialties" column so you have a better idea of who can help out with js Mar 04 10:16:50 <barry> sinzui: thanks. did you have anything else on this topic? Mar 04 10:16:56 <sinzui> no Mar 04 10:17:17 <barry> cool, anybody have anything else on any topic not on the agenda? Mar 04 10:17:18 <mars> s/specialties/mentoring offered/ ? Mar 04 10:17:30 <barry> mars: sup to the reviewer i guess Mar 04 10:18:27 <barry> [TOPIC] mentoring update Mar 04 10:18:28 <MootBot> New Topic: mentoring update Mar 04 10:18:35 <barry> * al-maisan graduates Mar 04 10:18:43 <barry> but he's not here :) Mar 04 10:18:58 <adeuring> congart al-maisan! Mar 04 10:19:04 <barry> * noodles to start js reviews this cycle, official mentat status next cycle Mar 04 10:19:30 <barry> noodles775: we'll figure out a mentor/ocr for you next cycle. welcome aboard! Mar 04 10:19:36 <noodles775> Thanks! Mar 04 10:20:10 <barry> [TOPIC] action items Mar 04 10:20:16 <MootBot> New Topic: action items Mar 04 10:20:19 <barry> * gary to add `getStore()` as an alias for `_get_store()` Mar 04 10:20:32 <barry> gary's not here though. does anybody know if this happened? Mar 04 10:21:15 <barry> * flacoste to look into storm/sqlobject result set compatibility Mar 04 10:21:34 <flacoste> barry: gary still needs to do this, he's on a sprint so has an excuse Mar 04 10:21:42 <barry> cool :) Mar 04 10:21:47 <flacoste> barry: i replied with a possible solution to gavin yesterday Mar 04 10:21:54 <flacoste> barry: he can tell if it works or not :-) Mar 04 10:22:01 <barry> excellent, thanks! Mar 04 10:22:05 <allenap> flacoste: I'll be putting that in my branch later today. Mar 04 10:22:12 <allenap> Thank you :) Mar 04 10:22:16 <barry> allenap: great, let us know how it works Mar 04 10:22:23 <flacoste> allenap: if it works, i'd suggest you add it to storm itself Mar 04 10:22:24 <allenap> Will do. Mar 04 10:22:31 <barry> well, *if* it works :) Mar 04 10:22:38 <allenap> flacoste: Good idea! Mar 04 10:23:01 <barry> * gary will check to see if there's a bug open for adding a hook to `bzr send`, and submit one if there isn't Mar 04 10:23:09 <barry> gary's sprinting so we won't worry about this one Mar 04 10:23:16 <barry> * bigjools to take crack at helper functions for backpatching schemas to avoid circular imports Mar 04 10:23:23 <barry> and bigjools isn't here (sprinting?) Mar 04 10:23:31 <barry> * abentley to experiment on storm base class Mar 04 10:23:50 <barry> nor is abentley, but does anybody know what the status of his sugarstorm branch is? Mar 04 10:24:55 <barry> i have not done my three action items, but now i have access to to the old wiki again, so i'm going to try to find some time to migrate/update Mar 04 10:25:03 <barry> * flacoste to work on API reviewer cheat sheet Mar 04 10:25:07 * flacoste hides Mar 04 10:25:31 <barry> no worries hoover :) keep it on the list? Mar 04 10:26:05 <cprov> barry: bigjools is off (vacations) this week Mar 04 10:26:16 <barry> cprov: cool, thanks Mar 04 10:26:33 <barry> well. that's everything that i have. if there's nothing more we can break early Mar 04 10:26:48 <barry> 5 Mar 04 10:27:10 <barry> 4 Mar 04 10:27:20 <barry> 2 Mar 04 10:27:30 <barry> 1 Mar 04 10:27:40 <barry> #endmeeting
