launchpad development
ReviewerMeeting20090415
summary
log
Apr 15 10:00:21 <barry> #startmeeting Apr 15 10:00:22 <MootBot> Meeting started at 09:00. The chair is barry. Apr 15 10:00:22 <MootBot> Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] Apr 15 10:00:45 <barry> hello everyone and welcome to this week's ameu reviewers meeting. who's here today? Apr 15 10:00:54 <intellectronica> me Apr 15 10:00:54 <abentley> me Apr 15 10:00:55 <mars> me Apr 15 10:01:21 <gary_poster> me Apr 15 10:02:01 <allenap> me Apr 15 10:02:13 <EdwinGrubbs> me Apr 15 10:02:18 <barry> adeuring, bac ping Apr 15 10:02:20 * flacoste (n=francis@canonical/launchpad/flacoste) has joined #launchpad-meeting Apr 15 10:02:23 <cprov> me Apr 15 10:02:26 <flacoste> me Apr 15 10:02:27 <barry> bigjools, BjornT ping Apr 15 10:02:34 <barry> danilo_: ping Apr 15 10:02:35 <adeuring> me, sorry for the delay Apr 15 10:02:38 <bac> me Apr 15 10:02:46 <barry> gmb: ping Apr 15 10:03:04 <barry> rockstar, salgado, sinzui ping Apr 15 10:03:16 <salgado> me Apr 15 10:03:22 <barry> [TOPIC] agenda Apr 15 10:03:24 <MootBot> New Topic: agenda Apr 15 10:03:37 <barry> * Roll call Apr 15 10:03:37 <barry> * Action items Apr 15 10:03:37 <barry> * Mentoring update Apr 15 10:03:37 <barry> * Peanut gallery (anything not on the agenda) Apr 15 10:03:38 <sinzui> mo Apr 15 10:03:41 <sinzui> me Apr 15 10:03:47 <barry> pretty light day today (planned at least) Apr 15 10:04:02 <barry> [TOPIC] action items Apr 15 10:04:03 <MootBot> New Topic: action items Apr 15 10:04:07 <rockstar> me Apr 15 10:04:11 <barry> * danilo to look into storm/sqlobject result set compatibility Apr 15 10:04:32 <barry> is danilo_ here today? flacoste do you have any status on this? Apr 15 10:04:38 <BjornT> me Apr 15 10:04:40 <flacoste> danilo? Apr 15 10:04:45 <flacoste> that was allenap Apr 15 10:04:54 <flacoste> backporting the patch he landed on storm trunk Apr 15 10:05:03 <allenap> I forgot :( Apr 15 10:05:09 <barry> flacoste: oops! Apr 15 10:05:16 <gmb> me Apr 15 10:05:23 <allenap> Please assign to me and I'll try and do it this time :) Apr 15 10:05:43 <barry> allenap: done, thanks Apr 15 10:05:52 <barry> * gary_poster will check to see if there's a bug open for adding a hook to `bzr send`, and submit one if there isn't Apr 15 10:06:04 <gary_poster> no sorry Apr 15 10:06:08 <gary_poster> will put back on my list Apr 15 10:06:13 <barry> gary_poster: cool, thanks Apr 15 10:06:21 <barry> * flacoste to work on API reviewer cheat sheet Apr 15 10:06:24 <rockstar> gary_poster, barry, abentley has a branch that he's been working on the forever. Apr 15 10:06:41 <gary_poster> rockstar: ok cool, I'll ask him about it Apr 15 10:06:44 <flacoste> barry: no progress since last week Apr 15 10:06:49 <barry> np Apr 15 10:06:53 <flacoste> barry: keep it up, i like this weekly "i suck" reminder :-) Apr 15 10:06:57 <barry> :-D Apr 15 10:06:58 <gary_poster> :-) Apr 15 10:07:02 <flacoste> good for keeping the ego in leash Apr 15 10:07:14 <abentley> gary_poster: I've done the support for specifying a body when sending, but not adding the hook. Apr 15 10:07:43 <gary_poster> abentley: cool. I'm guessing it's not on your immediate plate to finish it up? Apr 15 10:07:57 <abentley> gary_poster: Right. Apr 15 10:08:01 <gary_poster> understood Apr 15 10:08:09 <gary_poster> thanks Apr 15 10:08:34 <barry> [TOPIC] mentoring update Apr 15 10:08:35 <MootBot> New Topic: mentoring update Apr 15 10:08:42 <abentley> barry: Did you get anywhere with adding body support to claws? Apr 15 10:08:42 <gary_poster> abentley: do you happen to know if there's a bug for this, and what it might be, if so? Apr 15 10:08:55 <abentley> gary_poster: I'm not aware of a bug for this. Apr 15 10:08:55 <barry> abentley: i didn't :( Apr 15 10:09:04 <gary_poster> abentley: ok cool. Apr 15 10:09:30 <gary_poster> barry: one to-do item scratched off ;-) ...but maybe needs to be replaced with another. Apr 15 10:09:50 <barry> gary_poster: i'll cross it off and you can let me know if you want another Apr 15 10:09:58 <gary_poster> barry: cool thanks Apr 15 10:10:13 <barry> am i right that only stub is still being mentored? Apr 15 10:11:16 <barry> i should ping a few folks to see if they're ready to be mentats Apr 15 10:11:33 <barry> i don't think there's many folks left who aren't revewiers Apr 15 10:11:58 <barry> anyway... Apr 15 10:12:02 <barry> [TOPIC] peanut gallery Apr 15 10:12:03 <MootBot> New Topic: peanut gallery Apr 15 10:12:14 <barry> do you guys have anything not on the agenda? Apr 15 10:12:41 <abentley> I am wondering if we have a policy on redundant assertions? Apr 15 10:12:54 <abentley> e.g. if foo; else: assert not foo Apr 15 10:13:12 <intellectronica> abentley: i thought the policy is that we always do this Apr 15 10:13:22 <intellectronica> but maybe it's not documented anywhere? Apr 15 10:13:28 <barry> intellectronica: we always have an else clause if there's an elif Apr 15 10:13:40 <barry> but if there's no elif we don't need an else+assert Apr 15 10:13:41 <intellectronica> oh, right Apr 15 10:13:42 <abentley> Why would we *always* do that? Apr 15 10:13:58 <rockstar> abentley's example seems to be different than what barry showed intellectronica Apr 15 10:14:12 <barry> abentley: doesn't make sense to me Apr 15 10:14:23 <rockstar> Yea, the else+assert seems a little silly, as though assert would catch something the if would not. Apr 15 10:14:26 <BjornT> abentley: do you have an example in our code? Apr 15 10:14:41 <abentley> BjornT: It was something I reviewed on Monday. Apr 15 10:14:44 <intellectronica> yes, sorry, i got confused. if there's only one if there's probably no need to do this, unless it's imprtant that the code fails at this point Apr 15 10:15:08 <abentley> https://code.edge.launchpad.net/~salgado/launchpad/bug-358498/+merge/5496 Apr 15 10:16:01 <barry> abentley: the one on line 16 can just as well be raise AssertionError(...) Apr 15 10:16:19 <salgado> in this specific case I wanted the assertion because the 'elif' block should be removed soon, at which point the assertion will become non-redundant Apr 15 10:16:21 <barry> and that does fall within our guidelines Apr 15 10:16:24 <abentley> barry: It's unreacable code. Apr 15 10:16:44 <barry> abentley: proven by the assertion? <wink> Apr 15 10:16:51 <abentley> barry: It can equally well be raise IAmSuperman Apr 15 10:17:33 <barry> abentley: the one on line 13 seems okay, but should have a message Apr 15 10:17:48 <abentley> barry: It just seems like the wrong use of asserts-- proving that Python isn't buggy. Apr 15 10:17:50 <BjornT> abentley: ok. i would replace that assert with a raise AssertionError Apr 15 10:17:57 <barry> salgado: you're saying the whole 8-14 block will be removed eventually? Apr 15 10:18:15 <barry> abentley: sorry, i was talk about the one in the else clause (first) Apr 15 10:18:30 <barry> i.e. line 16 is fine Apr 15 10:18:54 <barry> line 13, yeah, i suppose. doesn't bother me too much either way Apr 15 10:19:00 <abentley> barry: I thought asserts were for proving your own state wasn't buggy. Apr 15 10:19:31 <barry> abentley: yes, or that the state you're assuming to be the case actually is the case Apr 15 10:19:33 <abentley> Anyhow, I'll continue to say "I think this is redundant, but keep it if you like." Apr 15 10:19:45 <barry> abentley: +1, for the line 13 assert Apr 15 10:19:59 <barry> oh, yeah, line 16 isn't a change Apr 15 10:20:06 <barry> but still. or whatever. Apr 15 10:20:16 * salgado_ (n=salgado@189-46-175-24.dsl.telesp.net.br) has joined #launchpad-meeting Apr 15 10:20:27 <abentley> barry: line 13 can't be reached because of line 6. Apr 15 10:20:27 <barry> abentley: thanks Apr 15 10:20:34 <barry> abentley: yep Apr 15 10:20:56 * salgado has quit (Nick collision from services.) Apr 15 10:20:58 * salgado_ is now known as salgado Apr 15 10:21:15 * barry agrees with abentley when he says: Anyhow, I'll continue to say "I think this is redundant, but keep it if you like." Apr 15 10:21:20 <BjornT> oh, we're talking about line 13. yes, that one should be removed Apr 15 10:22:01 <adeuring> well, yes, but salgado said that he will soon reorganize the code, so leaving this as a"reminder" is OK, IMHO Apr 15 10:22:35 <barry> agreed. maybe the assertion message (which salgado will add <wink>) should state something to that effect? Apr 15 10:23:14 <salgado> maybe. :) Apr 15 10:23:46 <barry> abentley: thanks for bringing this up Apr 15 10:23:53 <barry> anything more on this? Apr 15 10:23:56 <abentley> barry: np Apr 15 10:24:24 <barry> does anybody else have anything not on the agenda? Apr 15 10:25:24 <barry> 5 Apr 15 10:25:32 <barry> 4 Apr 15 10:25:33 <rockstar> Happy Tax Day! Apr 15 10:25:49 <barry> rockstar: "happy"?! Apr 15 10:25:50 <barry> 3 Apr 15 10:25:56 <barry> 2 Apr 15 10:26:01 <barry> 1 Apr 15 10:26:05 <barry> #endmeeting
