ReviewerMeeting20090603
summary
- henninge graduates
check out bzr+ssh://bazaar.launchpad.net/%7Elaunchpad/lpreview-body/trunk/
- remind devs to land javascript branches with [js] tags for qa purposes
logs
Jun 03 10:04:00 <barry> #startmeeting Jun 03 10:04:01 <MootBot> Meeting started at 09:04. The chair is barry. Jun 03 10:04:01 <MootBot> Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] Jun 03 10:04:14 <barry> hello and welcome to this week's ameu reviewer's meeting. who's here today? Jun 03 10:04:18 <sinzui> me Jun 03 10:04:19 <mars> me Jun 03 10:04:24 <gary_poster> me, and I didn't do what I was supposed to yet :-P Jun 03 10:04:31 <noodles775> me Jun 03 10:04:31 <adeuring> me Jun 03 10:04:36 <barry> rockstar: sends his apologies Jun 03 10:05:06 <barry> gary_poster: oh well, next week <wink> Jun 03 10:05:11 <gary_poster> :-) Jun 03 10:05:15 * flacoste (n=francis@24.202.83.45) has joined #launchpad-meeting Jun 03 10:05:28 <barry> allenap: ping Jun 03 10:05:30 <barry> bac: ping Jun 03 10:05:36 <barry> BjornT: ping Jun 03 10:05:40 <bac> me Jun 03 10:05:41 <barry> cprov: ping Jun 03 10:05:42 * abentley (n=abentley@CPE001a7046c8f9-CM001e6b233d5a.cpe.net.cable.rogers.com) has joined #launchpad-meeting Jun 03 10:05:45 <barry> danilos: ping Jun 03 10:05:46 <allenap> me Jun 03 10:05:47 <intellectronica> me Jun 03 10:05:48 <abentley> me Jun 03 10:05:51 <barry> EdwinGrubbs: ping Jun 03 10:06:00 <EdwinGrubbs> me Jun 03 10:06:07 <barry> flacoste: ping Jun 03 10:06:11 <flacoste> me Jun 03 10:06:13 <barry> gmb: ping Jun 03 10:06:26 <cprov> me Jun 03 10:06:26 <barry> salgado: ping Jun 03 10:06:50 <barry> just another minute... Jun 03 10:06:57 <danilos> me Jun 03 10:07:17 <barry> [TOPIC] agenda Jun 03 10:07:17 <MootBot> New Topic: agenda Jun 03 10:07:24 <barry> it's a light one today, not surprisingly Jun 03 10:07:29 <salgado> me Jun 03 10:07:32 <barry> * Roll call Jun 03 10:07:32 <barry> * Action items Jun 03 10:07:32 <barry> * Mentoring update Jun 03 10:07:32 <barry> * Peanut gallery (anything not on the agenda) Jun 03 10:07:41 <barry> [TOPIC] action items Jun 03 10:07:42 <MootBot> New Topic: action items Jun 03 10:07:49 <barry> we already know about gary_poster :) Jun 03 10:07:55 <barry> * flacoste to work on API reviewer cheat sheet Jun 03 10:07:56 <gary_poster> :-) Jun 03 10:08:03 * flacoste whistles innocently Jun 03 10:08:12 <barry> we already know about flacoste :) Jun 03 10:08:12 * ubuntulog has quit (Connection timed out) Jun 03 10:08:20 <danilos> do we still need it? Jun 03 10:08:30 <flacoste> i think we do Jun 03 10:08:36 <flacoste> paradoxically Jun 03 10:08:39 <noodles775> lol Jun 03 10:08:44 * ejat has quit (Remote closed the connection) Jun 03 10:08:49 <intellectronica> we've done quite good without it for a long tim Jun 03 10:08:53 <intellectronica> time, even Jun 03 10:08:53 <flacoste> well Jun 03 10:08:58 <danilos> ok, let me rephrase the question: is it worth keeping it in the agenda? Jun 03 10:09:03 <flacoste> maybe not Jun 03 10:09:09 <flacoste> i know i need to do it Jun 03 10:09:23 <barry> flacoste: i'll remove it. Jun 03 10:09:28 <flacoste> there is a lot of tricky issues in API export that are often missed Jun 03 10:09:33 * ubuntulo1 is now known as ubuntulog Jun 03 10:09:39 <flacoste> updating the URLs being an obvious one Jun 03 10:09:40 <barry> but i still think it would be a good thing to have Jun 03 10:09:47 <flacoste> but often things about the use of readonly Jun 03 10:10:01 <flacoste> the naming conventions are kind of understood Jun 03 10:10:01 <barry> esp. because this will go in our dev wiki so it will be helpful to outside contributors Jun 03 10:10:26 <flacoste> btw, in the coming weeks we should be able to use launchpadlib for API testing within launchpad Jun 03 10:10:43 <barry> flacoste: as a buildout benefit? Jun 03 10:10:45 <flacoste> once gary moves zope to buildout and we update all the lazr.* packages to the latest version Jun 03 10:10:54 <flacoste> barry: right on Jun 03 10:11:02 <barry> nice! Jun 03 10:11:06 <flacoste> btw, anybody noticed the improved tags with buildout? Jun 03 10:11:16 * ejat (n=fenris@218.111.34.6) has joined #launchpad-meeting Jun 03 10:11:24 <barry> flacoste: not yet! Jun 03 10:11:47 <flacoste> try it out! you can jump to symbol in the stdlib or stuff in any eggs Jun 03 10:12:03 <barry> flacoste: bin/tags tracebacks for me Jun 03 10:12:09 <flacoste> oops Jun 03 10:12:21 <flacoste> ok, we'll look into this Jun 03 10:12:29 <barry> flacoste: cool, thanks! Jun 03 10:12:53 <barry> between that and jml most awesome emacs module, you will never lose a symbol again Jun 03 10:13:00 <barry> moving on... Jun 03 10:13:05 <barry> [TOPIC] mentoring update Jun 03 10:13:06 <MootBot> New Topic: mentoring update Jun 03 10:13:15 <barry> any feedback from mentors or mentats? Jun 03 10:13:36 <adeuring> I think it is time for Henning to graduate Jun 03 10:13:52 <barry> adeuring: soon as he shows up to a reviewer's meeting <wink> Jun 03 10:14:11 <noodles775> I'm still enjoying Celso's mentoring :), looking forward to getting back into it tomorrow after the 2 week break. Jun 03 10:14:13 <barry> adeuring: serious, that's great Jun 03 10:14:28 <barry> noodles775: excellent! Jun 03 10:14:31 <noodles775> BTW: I think he's resting from Ubuflu at the moment... Jun 03 10:14:49 <barry> :( Jun 03 10:14:55 <barry> cool, anything else? Jun 03 10:15:12 <barry> [TOPIC] peanut gallery Jun 03 10:15:13 <MootBot> New Topic: peanut gallery Jun 03 10:15:51 <barry> anybody have anything not on the agenda? any barcelonan epiphanies about reviews? Jun 03 10:16:02 <intellectronica> remind your mentats to land javascript branches with [js] in the commit message Jun 03 10:16:12 <abentley> Now that bzr 1.5 is out, everyone should check out bzr+ssh://bazaar.launchpad.net/%7Elaunchpad/lpreview-body/trunk/ Jun 03 10:16:50 <abentley> This is a bzr plugin that automatically sets the message body for an lp review request to our standard template, and includes lint output. Jun 03 10:16:50 <barry> intellectronica: do we have a pqm regexp for that now? Jun 03 10:17:03 <noodles775> niice Jun 03 10:17:20 <cprov> err, sorry, was preparing a tea. Jun 03 10:17:27 <abentley> Of course, this only works with bzr send, so this is a good reason for everyone to use bzr send. Jun 03 10:17:32 <intellectronica> barry: no. we'd have to inspect the diff for something like that to work Jun 03 10:17:45 <noodles775> cprov: you're meant to be sleeping off your headache :) Jun 03 10:18:01 <cprov> barry: noodles775 is doing great reviews, his graduation will come soon too. Jun 03 10:18:21 <barry> intellectronica: so is this a [js=somebody] tag? Jun 03 10:18:26 <barry> cprov: fantastic Jun 03 10:18:41 <intellectronica> barry: no, just [js] Jun 03 10:18:57 <intellectronica> to indicate that the branch requires testing on multiple platforms Jun 03 10:18:58 <danilos> abentley: bzr send is good, can you email the list about the plugin as well Jun 03 10:19:00 <abentley> Also, with the recent launchpad changes, you don't need to push before you send, and you don't need to use lpsend or send --no-bundle. Jun 03 10:19:03 <mars> barry, it is just a flag to QA that somebody needs to look at the branch in all the browsers Jun 03 10:19:10 <danilos> abentley: perhaps document it on dev.launchpad.net as well Jun 03 10:19:10 <barry> intellectronica: k. do all devs know about that? maybe a msg to launchpad@ to remind people? Jun 03 10:19:33 <intellectronica> barry: we already had a message. i can send another one Jun 03 10:19:35 <abentley> danilos: Okay, but I already emailed the list, and no one responded, so I thought I should bring it up here. Jun 03 10:19:42 * noodles775 has quit (Read error: 104 (Connection reset by peer)) Jun 03 10:19:56 <barry> intellectronica: might not be a bad idea to remind people Jun 03 10:20:11 <danilos> abentley: ^^ :) Jun 03 10:20:35 <danilos> abentley: I am certainly going to check it out Jun 03 10:20:42 <barry> abentley: yes, document on the dev wiki, and this sounds awesome Jun 03 10:21:37 <abentley> barry: will do. Jun 03 10:21:53 <barry> abentley: thanks! Jun 03 10:22:00 <barry> anything else guys? Jun 03 10:22:29 <barry> 5 Jun 03 10:22:34 <barry> 4 Jun 03 10:22:38 * noodles775 (n=miken@g225071237.adsl.alicedsl.de) has joined #launchpad-meeting Jun 03 10:22:38 <abentley> barry: It's not open-source, so does it make sense to document on the dev wiki? Jun 03 10:23:21 <barry> abentley: i think it's fine. i'd still rather have one place to find relevant information, but i'll leave it up to you Jun 03 10:23:40 <barry> abentley: is there any reason it /can't/ be open source? Jun 03 10:24:04 <abentley> barry: Needs signoff from Mark or the holy trinity, and that hasn't happened yet. Jun 03 10:24:09 * ejat has quit (Remote closed the connection) Jun 03 10:24:30 * test32 (n=patrick@zero.positive-internet.com) has joined #launchpad-meeting Jun 03 10:24:32 <barry> abentley: ok. i'd say document it on the dev wiki and we can work toward open sourcing it Jun 03 10:24:37 * andrea-bs (n=andrea@ubuntu/member/beeseek.developer.andrea-bs) has joined #launchpad-meeting Jun 03 10:24:46 * test32 has quit (Client Quit) Jun 03 10:24:54 <abentley> barry: The ball is currently in kiko's court on open-sourcing. Jun 03 10:25:22 <barry> abentley: let's keep the jfdi pressure on kiko then! :) Jun 03 10:25:43 <barry> anybody have anything else? Jun 03 10:25:52 <abentley> barry: See https://wiki.canonical.com/OpenSource/Process Jun 03 10:26:09 <barry> yeah Jun 03 10:26:19 <barry> 5 Jun 03 10:26:27 <barry> 4 Jun 03 10:26:33 <barry> 3 Jun 03 10:26:39 <barry> 2 Jun 03 10:26:47 <barry> 1 Jun 03 10:26:50 <barry> #endmeeting