|Deletions are marked like this.||Additions are marked like this.|
|Line 15:||Line 15:|
|* Barry Warsaw (barry)|
These guidelines are to help all of us make UI reviews as straight-forward as possible.
For a detailed process for UI changes: VersionThreeDotO/UI/Conversion
Current UI reviewers
- Martin Albisetti (beuno)
- Maris Fogels (mars)
- Paul Hummer (rockstar)
- Michael Nelson (noodles)
Edwin Grubbs (EdwinGrubbs)
- Tom Berger (intellectronica)
- Curtis Hovey (sinzui)
- Barry Warsaw (barry)
10 questions to ask yourself before starting a branch
- Is there any other page in Launchpad that does something similar?
- Will this add any value to users?
- Will this make it harder for other users to complete tasks?
- How would you "tweet" this change? (i.e. describe in 140 characters)?
- Are there any other pages that should change their behavior/look with this change? 6... 7... 8... 9... 10...
What is this page trying to tell me
Although it may be out of the scope of the current branch that you are working on, it is always worthwhile getting the big-picture... and there might be small improvements outside the scope of your bug that will make a huge difference to the user experience. (Maris' to add notes)
Submitting your branch for review
10 questions to ask yourself before submitting
- What value does this add to users?
- Will this make it harder to complete any tasks?
- Will this make it easier to complete any tasks?
- Does this behave differently than other pages in Launchpad?
- Does completing the task require prior knowledge? Is that knowledge available as help?
- How many more knobs and buttons have I added?
- Is it easy to explain?
- What can I do to make it explaining it easier, or even unnecessary?
- Is it fun to use?
- Can this be simpler?
Create a screenshot or screencast
The UI review process will be much faster if the reviewer can view your change without having to merge and run your branch. Sometimes this can be as simple as attaching screenshots to the bug (this also allows other interested people to comment).
If your UI change involves a behaviour, consider creating a brief screen-cast using gtkRecordMyDesktop and attaching it to the bug. Again, this will again help the reviewer and other interested people from commenting without having to merge your branch.
Tips for reviewers
Don't read the merge proposal. Branch, fire up the page(s) that where changed, and write down your initial impressions. Sometimes a change causes other parts of the page to look out of place, so knowing what to look at may make you miss that.
Make mistakes. When going through a work flow, make as many mistakes on purpose. This will help you feel what a frustration scenario would look like.