launchpad development|
⇤ ← Revision 1 as of 2009-04-10 15:27:22
Size: 1803
Comment: Initial draft of this page.
|
Size: 1799
Comment: Formatting tweak.
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 10: | Line 10: |
| 1. Push the branch up to your Launchpad user account: ''{{{bzr push my_local_bugfix123_branch lp:~my_username/launchpad/bugfix123}}}'' | 1. Push the branch up to your Launchpad user account: '''{{{bzr push my_bugfix123_branch lp:~my_username/launchpad/bugfix123}}}''' |
Submitting a Patch to Launchpad
This page covers the process of getting a code change into Launchpad. You should already have your Launchpad sources (see Rocketfuel Setup) and be familiar with the coding style guidelines.
- Make sure your change is about one single thing (say, a specific bugfix), and that all the revisions for it are committed on your Bazaar branch.
Push the branch up to your Launchpad user account: bzr push my_bugfix123_branch lp:~my_username/launchpad/bugfix123
Run tests on your branch. If the tests don't pass, go back to hacking, commit new changes, re-push, and re-test. Repeat until the branch passes.
Please send in your contributor agreement form now (it's an easy email process). We can't accept the change without a contributor agreement.
Find someone to review the branch. Usually, this is a Launchpad developer you've already been talking to about the change. You can also go into the IRC channel #launchpad-dev on irc.freenode.net and see who's available to do review, or post to the development mailing list. See also Code Review.
Propose your branch for merging, by going to https://code.launchpad.net/~my_username/launchpad/bugfix123 and click on Propose for merging into another branch. (The branch to merge into is lp:~launchpad-pqm/launchpad/devel.) Fill in the field for requested reviewer with the name of the reviewer you found, and follow the guidelines for writing the merge cover letter.
Once the reviewer approves the change, merge it into Launchpad: ...working here...
