launchpad development|
Size: 1799
Comment: Formatting tweak.
|
Size: 2167
Comment: Update based on andrea-bs experience.
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 9: | Line 9: |
| 1. Before making your change, it's a good idea to talk about it first to a Launchpad developer. The easiest way there is to ask the person listed as 'Help contact' in the `#launchpad` IRC channel on `irc.freenode.net`. That "pre-implementation chat" will make sure that you have all things covered. | |
| Line 13: | Line 14: |
| 1. Find someone to review the branch. Usually, this is a Launchpad developer you've already been talking to about the change. You can also go into the IRC channel `#launchpad-dev` on `irc.freenode.net` and see who's available to do review, or post to the development mailing list. See also [[Reviews|Code Review]]. | |
| Line 15: | Line 15: |
| 1. Once the reviewer approves the change, merge it into Launchpad: {{{...working here...}}} | 1. Find someone to review the branch. Usually, this would be the Launchpad developer with whom you had your "pre-implementation" chat about the change. If he's not available, you can ask the 'Help contact' in the `#launchpad` channel on `irc.freenode.net` to point you at somebody else who could make the review. See also [[Reviews|Code Review]]. 1. Once the reviewer approves the change, he'll take care of merging your changes (that's until we work an automated process). |
Submitting a Patch to Launchpad
This page covers the process of getting a code change into Launchpad. You should already have your Launchpad sources (see Rocketfuel Setup) and be familiar with the coding style guidelines.
Before making your change, it's a good idea to talk about it first to a Launchpad developer. The easiest way there is to ask the person listed as 'Help contact' in the #launchpad IRC channel on irc.freenode.net. That "pre-implementation chat" will make sure that you have all things covered.
- Make sure your change is about one single thing (say, a specific bugfix), and that all the revisions for it are committed on your Bazaar branch.
Push the branch up to your Launchpad user account: bzr push my_bugfix123_branch lp:~my_username/launchpad/bugfix123
Run tests on your branch. If the tests don't pass, go back to hacking, commit new changes, re-push, and re-test. Repeat until the branch passes.
Please send in your contributor agreement form now (it's an easy email process). We can't accept the change without a contributor agreement.
Propose your branch for merging, by going to https://code.launchpad.net/~my_username/launchpad/bugfix123 and click on Propose for merging into another branch. (The branch to merge into is lp:~launchpad-pqm/launchpad/devel.) Fill in the field for requested reviewer with the name of the reviewer you found, and follow the guidelines for writing the merge cover letter.
Find someone to review the branch. Usually, this would be the Launchpad developer with whom you had your "pre-implementation" chat about the change. If he's not available, you can ask the 'Help contact' in the #launchpad channel on irc.freenode.net to point you at somebody else who could make the review. See also Code Review.
- Once the reviewer approves the change, he'll take care of merging your changes (that's until we work an automated process).
