launchpad development|
Size: 3153
Comment:
|
Size: 1198
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 1: | Line 1: |
| = Hacking Launchpad = | = Review = |
| Line 3: | Line 3: |
| These pages describe processes and guidelines for developing the software that runs Launchpad. It includes tips for coders and tips for reviewers, as well as public meeting notes, and anything else that is useful to people actually writing and reviewing Launchpad code. Start here if you like to get your hands dirty. == Developer resources == * Coming soon... == Reviewer resources == No changes to Launchpad can land without being reviewed and approved by at least one other person. Our goal is for every Launchpad developer to also be a reviewer, and to that end we have a mentoring process to initiate new |
All changes to Launchpad need to be reviewed and approved by a reviewer. Most changes should have that reviewer be someone other than the author of the change. Changes made by a reviewer who is confident that the risk of the change being harmful is less than the cost of having it reviewed may be landed without a second reviewers feedback. Our goal is for every Launchpad developer to also be a reviewer, and to that end we have a mentoring process to initiate new |
| Line 25: | Line 10: |
| Here is the current list of reviewers. No mentor is listed if the person is a graduated reviewer. ''OCR'' is the time slot that the reviewer is on-call. || '''Name''' || '''irc nick''' || '''OCR''' || '''mentor''' || || Aaron Bentley || abentley || Monday/West || || || Abel Deuring || abel || Wednesday/Euro || salgado || || Barry Warsaw || barry || Friday/West || || || Bjorn Tillenius || BjornT || || || || Brad Crittenden || bac || Tuesday/West || || || Celso Providelo || cprov || Wednesday/West || || || Christian Reis || kiko || || || || Curtis Hovey || sinzui || || || || Danilo Segan || danilo || Tuesday/Euro || || || Edwin Grubbs || Edwin || Thursday/West || || || Francis Lacoste || flacoste || || || || Gavin Panella || allenap || Wednesday/Euro || || || Graham Binns || gmb || Monday/Euro || || || Guilherme Salgado || salgado || Friday/West || || || Jeroen Vermeulen || jtv || || || || Jonathan Lange || jml || Friday/East || || || Julian Edwards || bigjools || || || || Maris Fogels || mars || Thursday/Euro || || || Michael Hudson || mwhudson || Thursday/East || || || Muharem Hrnjadovic || al-maisan || Monday/Euro || gmb || || Paul Hummer || rockstar || Tuesday/West || || || Stuart Bishop || stub || || || || Tim Penhey || thumper || || || || Tom Berger || intellectronica || (sabbatical) || || Here are the list of on-call reviewers, organized by time slot: || '''Day''' || '''East (Asia``Pac)''' || '''Europe''' || '''West (Americas)''' || || Monday || || GrahamBinns, MuharemHrnjadovic (mentor: gmb) || AaronBentley || || Tuesday || || DaniloSegan || BradCrittenden, PaulHummer || || Wednesday || || GavinPanella, AbelDeuring (mentor: allenap) || CelsoProvidelo || || Thursday || MichaelHudson || MarisFogels || EdwinGrubbs || || Friday || JonathanLange || || GuilhermeSalgado, BarryWarsaw || |
The list of reviewers and their on-call schedule is [[ReviewerSchedule||available here]]. |
| Line 66: | Line 14: |
| * Coming soon. | * PreMergeReviews |
| Line 68: | Line 16: |
| We also conduct two weekly reviewer meetings on a public IRC channel. One | We have on-demand reviewer meetings on a public IRC channel. One |
Review
All changes to Launchpad need to be reviewed and approved by a reviewer. Most changes should have that reviewer be someone other than the author of the change. Changes made by a reviewer who is confident that the risk of the change being harmful is less than the cost of having it reviewed may be landed without a second reviewers feedback. Our goal is for every Launchpad developer to also be a reviewer, and to that end we have a mentoring process to initiate new developers onto the review team. Every "mentat" (new reviewer) is assigned a mentor (experienced reviewer) to help guide them through the process. Mentats do the reviews and the mentor reviews the mentat's review. When the mentor and review team lead agree that the mentat is ready to leave the nest, the mentat is graduated and becomes a full-fledged reviewer.
The list of reviewers and their on-call schedule is ReviewerSchedule.
Here are resources we've established to help reviewers:
We have on-demand reviewer meetings on a public IRC channel. One meeting is for Antipodeans, and the other is for Europeans and Americans.
