7376
Comment:
|
7694
|
Deletions are marked like this. | Additions are marked like this. |
Line 13: | Line 13: |
* Asia``Pac '''Wednesday 25-Feb-2009 2300 UTC - 2345 UTC''' * AMEU '''Wednesday 25-Feb-2009 1500 UTC - 1545 UTC''' |
* AMEU '''Wednesday 22-Apr-2009 1500 UTC - 1545 UTC''' * Asia``Pac '''Wednesday 22-Apr-2009 2230 UTC - 2315 UTC''' |
Line 22: | Line 22: |
* Reviewers to enforce bug<->branch linking for all non-trivial branches (intellectronica) * Determine official preference, if any, of Storm usage: And(expr, expr) vs. expr & expr, Gary * Determine why _get_store uses protected spelling, and if we think it should, Gary * Merge proposals and cover letters (barry) |
* Action items * Mentoring update |
Line 27: | Line 25: |
* Mentoring update * Action items |
|
Line 38: | Line 34: |
* bigjools to take crack at helper functions for backpatching schemas to avoid circular imports * intellectronica to come back from sabbatical * thumper to open bug on `webservice` pagetests globs problem * abentley to experiment on storm base class * barry to add `field_id` to coding guideline * barry to update guidelines to never call `_foo()` methods from outside a class * barry to add `pretty()` functions to reviewers docs |
* allenap to look into storm/sqlobject result set compatibility |
Line 49: | Line 39: |
gary writes: * What is the goal (are the goals?) of our use of security proxies and the import nazi? My understanding is that they are "belt and suspenders" to try and keep us from revealing private information. * Do we still agree with those goals? * Do we feel that our use of security proxies helps us with these goals? * Do we feel that our use of the import nazi helps us with these goals? As we know, security is very hard, and trying to answer these questions well should not be done lightly or too quickly. I am hopeful that the small, specific question of whether we should import removeSecurityProxies in view code will fall out obviously, if not easily, from our answers to the discussion above. |
|
Line 52: | Line 56: |
* don't return unwrapped objects from view methods, barry and gary ("the fightin' arries!") | |
Line 56: | Line 61: |
* [[ReviewerMeeting20090415]] * [[ReviewerMeeting20090408]] * [[ReviewerMeeting20090318]] * [[ReviewerMeeting20090311]] * [[ReviewerMeeting20090304]] * [[ReviewerMeeting20090225]] |
Agenda of the next Launchpad review team meeting
Launchpad review team meetings are held on #launchpad-meeting on irc.freenode.net, and are chaired by BarryWarsaw for both the Asia/Pacific (AsiaPac) and Americas/EU (AMEU) time zone meetings. We use MootBot to record the meetings.
The purpose of the meetings is to coordinate Launchpad code reviews, and particularly to ensure that emerging issues with the review process are addressed - such as getting people to take on tough reviews, keeping the latency down, etc.. Blockage in reviews leads to blockage in Launchpad code landings.
The next Launchpad review team meeting will be held at this time:
AMEU Wednesday 22-Apr-2009 1500 UTC - 1545 UTC
AsiaPac Wednesday 22-Apr-2009 2230 UTC - 2315 UTC
You can add new items to the list of proposed items. If they don't make it onto this meetings agenda, they'll most likely get onto the next meeting's agenda instead.
Agenda
- Roll call
- Action items
- Mentoring update
- Peanut gallery (anything not on the agenda)
Apologies
Please include the date for which you will be unavailable.
- your name, date
Outstanding Actions
- allenap to look into storm/sqlobject result set compatibility
- flacoste to work on API reviewer cheat sheet
Notes
gary writes:
- What is the goal (are the goals?) of our use of security proxies and the import nazi? My understanding is that they are "belt and suspenders" to try and keep us from revealing private information.
- Do we still agree with those goals?
- Do we feel that our use of security proxies helps us with these goals?
- Do we feel that our use of the import nazi helps us with these goals?
As we know, security is very hard, and trying to answer these questions well should not be done lightly or too quickly.
I am hopeful that the small, specific question of whether we should import removeSecurityProxies in view code will fall out obviously, if not easily, from our answers to the discussion above.
Proposed items
- your topic, your name
- don't return unwrapped objects from view methods, barry and gary ("the fightin' arries!")
Rejected items