7420
Comment:
|
7389
|
Deletions are marked like this. | Additions are marked like this. |
Line 13: | Line 13: |
* Asia``Pac '''Wednesday 04-Mar-2009 2230 UTC - 2315 UTC''' * AMEU '''Wednesday 04-Mar-2009 1500 UTC - 1545 UTC''' |
* AMEU '''Wednesday 17-Jun-2009 1500 UTC - 1545 UTC''' * Asia``Pac '''Wednesday 17-Jun-2009 2230 UTC - 2315 UTC''' |
Line 22: | Line 22: |
* Reviewers to enforce bug<->branch linking for all non-trivial branches (intellectronica) * Determine official preference, if any, of Storm usage: And(expr, expr) vs. expr & expr, Gary * Determine why _get_store uses protected spelling, and if we think it should, Gary * Merge proposals and cover letters (barry) * Using OCR for JavaScript reviews (mars) |
* Action items * Mentoring update |
Line 28: | Line 25: |
* Mentoring update * Action items |
* naming of unittest methods (Camel``Case or under_scores) (henninge) * order of assert parameters (expected, observed) (hennige) * Driving maintainable Javascript code (intellectronica) * Modularization and unit testing are strongly encouraged * Refactoring code after a UI review is often a good idea * The upper limit for JS diffs is 1600 lines (because javascript is so verbose) |
Line 35: | Line 36: |
* your name, date |
|
Line 39: | Line 38: |
* bigjools to take crack at helper functions for backpatching schemas to avoid circular imports * intellectronica to come back from sabbatical * thumper to open bug on `webservice` pagetests globs problem * abentley to experiment on storm base class * barry to add `field_id` to coding guideline * barry to update guidelines to never call `_foo()` methods from outside a class * barry to add `pretty()` functions to reviewers docs * flacoste to work on API reviewer cheat sheet |
* gary_poster to take importfascist and rSP() discussion to ml |
Line 57: | Line 49: |
* [[ReviewerMeeting20090610]] * [[ReviewerMeeting20090603]] * [[ReviewerMeeting20090513]] * [[ReviewerMeeting20090506]] * [[ReviewerMeeting20090429]] * [[ReviewerMeeting20090422]] * [[ReviewerMeeting20090415]] * [[ReviewerMeeting20090408]] * [[ReviewerMeeting20090318]] * [[ReviewerMeeting20090311]] * [[ReviewerMeeting20090304]] * [[ReviewerMeeting20090225]] |
Agenda of the next Launchpad review team meeting
Launchpad review team meetings are held on #launchpad-meeting on irc.freenode.net, and are chaired by BarryWarsaw for both the Asia/Pacific (AsiaPac) and Americas/EU (AMEU) time zone meetings. We use MootBot to record the meetings.
The purpose of the meetings is to coordinate Launchpad code reviews, and particularly to ensure that emerging issues with the review process are addressed - such as getting people to take on tough reviews, keeping the latency down, etc.. Blockage in reviews leads to blockage in Launchpad code landings.
The next Launchpad review team meeting will be held at this time:
AMEU Wednesday 17-Jun-2009 1500 UTC - 1545 UTC
AsiaPac Wednesday 17-Jun-2009 2230 UTC - 2315 UTC
You can add new items to the list of proposed items. If they don't make it onto this meetings agenda, they'll most likely get onto the next meeting's agenda instead.
Agenda
- Roll call
- Action items
- Mentoring update
- Peanut gallery (anything not on the agenda)
naming of unittest methods (CamelCase or under_scores) (henninge)
- order of assert parameters (expected, observed) (hennige)
- Driving maintainable Javascript code (intellectronica)
- Modularization and unit testing are strongly encouraged
- Refactoring code after a UI review is often a good idea
- The upper limit for JS diffs is 1600 lines (because javascript is so verbose)
Apologies
Please include the date for which you will be unavailable.
Outstanding Actions
- gary_poster to take importfascist and rSP() discussion to ml
Notes
Proposed items
- your topic, your name
Rejected items