6626
Comment:
|
8445
|
Deletions are marked like this. | Additions are marked like this. |
Line 13: | Line 13: |
* Asia``Pac '''Tuesday 18-Nov-2008 0300 UTC - 0345 UTC''' * AMEU '''Wednesday 12-Nov-2008 1500 UTC - 1545 UTC''' |
* AMEU '''Wednesday 06-Jan-2010 1500 UTC - 1545 UTC''' * Asia``Pac '''Wednesday 06-Jan-2010 2100 UTC - 2145 UTC''' |
Line 22: | Line 22: |
* What support can beuno and mrevell offer during the review process? (mrevell) * Email cover letter to ml after pre-imp call? - barry * If there's time, the old boring script * Next meeting * Action items * Queue status * Mentoring update |
* Action items * year end schedule [barry] * invite other teams to do lazr-js code reviews? [mars/barry] * Peanut gallery (anything not on the agenda) |
Line 34: | Line 31: |
* your name, date, reason * gmb, 2008-11-12, November Nexus @ Lexington |
* ''yourname, date'' |
Line 39: | Line 35: |
* flacoste and foundations to look into techniques for eliminating back-patching of schema types (avoiding circular imports) * rockstar to take discussion of adding launchpadlib tests for exposed api to ml * abentley to investigate current code coverage tools for lp tests |
* intellectronica and barry to draft guidelines for drive-by cleanups |
Line 47: | Line 41: |
* Reminder: Who can do JS reviews? All reviewers? [henninge,allenap] * Proposed coding standard for YUI modules. * I think a file such as lib/canonical/launchpad/javascript/'''registry/timeline'''.js should define its module like this: {{{ YUI().add('registry.timeline', function (Y) { var module = Y.namespace('registry.timeline'); module.someFunction = function() {}; }); }}} * Then, the code could be accessed with: {{{ YUI().use('registry.timeline', function(Y) { Y.registry.timeline.someFunction(); }); }}} * The [[JavaScriptReviewNotes#Namespaces|javascript style guide] doesn't specify how modules should be named currently. * [[https://pastebin.canonical.com/25818/|Current inconsistencies]] * ''your item [your name]'' |
|
Line 50: | Line 61: |
* [[ReviewerMeeting20091125]] * [[ReviewerMeeting20091014]] * [[ReviewerMeeting20091007]] * [[ReviewerMeeting20090930]] * [[ReviewerMeeting20090923]] * [[ReviewerMeeting20090916]] * [[ReviewerMeeting20090909]] * [[ReviewerMeeting20090902]] * [[ReviewerMeeting20090826]] * [[ReviewerMeeting20090819]] * [[ReviewerMeeting20090812]] * [[ReviewerMeeting20090805]] * [[ReviewerMeeting20090729]] * [[ReviewerMeeting20090722]] * [[ReviewerMeeting20090715]] * [[ReviewerMeeting20090708]] * [[ReviewerMeeting20090701]] * [[ReviewerMeeting20090624]] * [[ReviewerMeeting20090617]] * [[ReviewerMeeting20090610]] * [[ReviewerMeeting20090603]] * [[ReviewerMeeting20090513]] * [[ReviewerMeeting20090506]] * [[ReviewerMeeting20090429]] * [[ReviewerMeeting20090422]] * [[ReviewerMeeting20090415]] * [[ReviewerMeeting20090408]] * [[ReviewerMeeting20090318]] * [[ReviewerMeeting20090311]] * [[ReviewerMeeting20090304]] * [[ReviewerMeeting20090225]] * [[ReviewerMeeting20090218]] * [[ReviewerMeeting20090211]] * [[ReviewerMeeting20090204]] * [[ReviewerMeeting20090128]] * [[ReviewerMeeting20090121]] * [[ReviewerMeeting20090114]] * [[ReviewerMeeting20090107]] * [[ReviewerMeeting20081217]] * [[ReviewerMeeting20081210]] * [[ReviewerMeeting20081209]] * [[ReviewerMeeting20081203]] * [[ReviewerMeeting20081126]] * [[ReviewerMeeting20081125]] |
Agenda of the next Launchpad review team meeting
Launchpad review team meetings are held on #launchpad-meeting on irc.freenode.net, and are chaired by BarryWarsaw for both the Asia/Pacific (AsiaPac) and Americas/EU (AMEU) time zone meetings. We use MootBot to record the meetings.
The purpose of the meetings is to coordinate Launchpad code reviews, and particularly to ensure that emerging issues with the review process are addressed - such as getting people to take on tough reviews, keeping the latency down, etc.. Blockage in reviews leads to blockage in Launchpad code landings.
The next Launchpad review team meeting will be held at this time:
AMEU Wednesday 06-Jan-2010 1500 UTC - 1545 UTC
AsiaPac Wednesday 06-Jan-2010 2100 UTC - 2145 UTC
You can add new items to the list of proposed items. If they don't make it onto this meetings agenda, they'll most likely get onto the next meeting's agenda instead.
Agenda
- Roll call
- Action items
- year end schedule [barry]
- invite other teams to do lazr-js code reviews? [mars/barry]
- Peanut gallery (anything not on the agenda)
Apologies
Please include the date for which you will be unavailable.
yourname, date
Outstanding Actions
- intellectronica and barry to draft guidelines for drive-by cleanups
Notes
Proposed items
- Reminder: Who can do JS reviews? All reviewers? [henninge,allenap]
- Proposed coding standard for YUI modules.
I think a file such as lib/canonical/launchpad/javascript/registry/timeline.js should define its module like this:
YUI().add('registry.timeline', function (Y) { var module = Y.namespace('registry.timeline'); module.someFunction = function() {}; });
Then, the code could be accessed with:
YUI().use('registry.timeline', function(Y) { Y.registry.timeline.someFunction(); });
The [[JavaScriptReviewNotes#Namespaces|javascript style guide] doesn't specify how modules should be named currently.
your item [your name]
Rejected items