launchpad development|
Size: 8565
Comment:
|
Size: 7823
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 13: | Line 13: |
| * AMEU '''Wednesday 06-Jan-2010 1500 UTC - 1545 UTC''' * Asia``Pac '''Wednesday 06-Jan-2010 2100 UTC - 2145 UTC''' |
* AMEU '''Wednesday 13-Jan-2010 1500 UTC - 1545 UTC''' * Asia``Pac '''Wednesday 13-Jan-2010 2100 UTC - 2145 UTC''' |
| Line 23: | Line 23: |
| * invite other teams to do lazr-js code reviews? [mars/barry] | |
| Line 34: | Line 33: |
| * intellectronica and barry to draft guidelines for drive-by cleanups | * intellectronica to draft guidelines for drive-by cleanups * invite other teams to do lazr-js code reviews? (See if this was sent to the ML.) [mars/bac] |
| Line 40: | Line 40: |
| * Reminder: Who can do JS reviews? All reviewers? [henninge,allenap] * Proposed coding standard for YUI modules. [Edwin] * I think a file such as lib/canonical/launchpad/javascript/'''registry/timeline'''.js should define its module like this: {{{ YUI().add('registry.timeline', function (Y) { var module = Y.namespace('registry.timeline'); module.someFunction = function() {}; }); }}} * Then, the code could be accessed with: {{{ YUI().use('registry.timeline', function(Y) { Y.registry.timeline.someFunction(); }); }}} * The [[JavaScriptReviewNotes#Namespaces|javascript style guide]] doesn't specify how modules should be named currently. * [[https://pastebin.canonical.com/25818/|Current inconsistencies]] * Cleaning up outstanding '''approved''' branches on [[https://code.edge.launchpad.net/launchpad/+activereviews| +activereviews]] [bac] * ''your item [your name]'' |
* Limit doctests to 200 lines [allenap] * security checks: ``try:...except UnauthorizedError:...`` vs. canView [gary] |
| Line 61: | Line 46: |
| * [[ReviewerMeeting20100106]] |
Agenda of the next Launchpad review team meeting
Launchpad review team meetings are held on #launchpad-meeting on irc.freenode.net, and are chaired by BradCrittenden for both the Asia/Pacific (AsiaPac) and Americas/EU (AMEU) time zone meetings. We use MootBot to record the meetings.
The purpose of the meetings is to coordinate Launchpad code reviews, and particularly to ensure that emerging issues with the review process are addressed - such as getting people to take on tough reviews, keeping the latency down, etc.. Blockage in reviews leads to blockage in Launchpad code landings.
The next Launchpad review team meeting will be held at this time:
AMEU Wednesday 13-Jan-2010 1500 UTC - 1545 UTC
AsiaPac Wednesday 13-Jan-2010 2100 UTC - 2145 UTC
You can add new items to the list of proposed items. If they don't make it onto this meetings agenda, they'll most likely get onto the next meeting's agenda instead.
Agenda
- Roll call
- Action items
- Peanut gallery (anything not on the agenda)
Apologies
Please include the date for which you will be unavailable.
yourname, date
Outstanding Actions
- intellectronica to draft guidelines for drive-by cleanups
- invite other teams to do lazr-js code reviews? (See if this was sent to the ML.) [mars/bac]
Notes
Proposed items
- Limit doctests to 200 lines [allenap]
security checks: try:...except UnauthorizedError:... vs. canView [gary]
Rejected items
