launchpad development|
Size: 8593
Comment:
|
Size: 8101
Comment:
|
| Deletions are marked like this. | Additions are marked like this. |
| Line 13: | Line 13: |
| * AMEU '''Wednesday 06-Jan-2010 1500 UTC - 1545 UTC''' * Asia``Pac '''Wednesday 06-Jan-2010 2100 UTC - 2145 UTC''' |
* AMEU '''Wednesday 20-Jan-2010 1500 UTC - 1545 UTC''' * Asia``Pac '''Wednesday 20-Jan-2010 2100 UTC - 2145 UTC''' |
| Line 23: | Line 23: |
| * invite other teams to do lazr-js code reviews? [mars/barry] | |
| Line 34: | Line 33: |
| * intellectronica and barry to draft guidelines for drive-by cleanups | * intellectronica to draft guidelines for drive-by cleanups * Maris to bring up cross-team reviews in the lazr-js task force meeting and report back. * Gavin to start discussion on the ML about doctest size, refactoring, moving corner cases to unittests, etc * Gary to do timing tests for try/except, examine current usage of check_permission, and we'll discuss again next week. * Curtis to land a import cleanup branch and then reviewers will enforce zero tolerance for introducing new issues. |
| Line 40: | Line 43: |
| * Reminder: Who can do JS reviews? All reviewers? [henninge,allenap] * Proposed coding standard for YUI modules. [Edwin] * I think a file such as lib/canonical/launchpad/javascript/'''registry/timeline'''.js should define its module like this: {{{ YUI().add('registry.timeline', function (Y) { var module = Y.namespace('registry.timeline'); module.someFunction = function() {}; }); }}} * Then, the code could be accessed with: {{{ YUI().use('registry.timeline', function(Y) { Y.registry.timeline.someFunction(); }); }}} * The [[JavaScriptReviewNotes#Namespaces|javascript style guide]] doesn't specify how modules should be named currently. * [[https://pastebin.canonical.com/25818/|Current inconsistencies]] * Cleaning up outstanding '''approved''' branches on [[https://code.edge.launchpad.net/launchpad/+activereviews| +activereviews]] [bac] * Meeting frequency [bac] * ''your item [your name]'' |
* topic [yourname] |
| Line 62: | Line 48: |
| * [[ReviewerMeeting20100113]] * [[ReviewerMeeting20100106]] |
Agenda of the next Launchpad review team meeting
Launchpad review team meetings are held on #launchpad-meeting on irc.freenode.net, and are chaired by BradCrittenden for both the Asia/Pacific (AsiaPac) and Americas/EU (AMEU) time zone meetings. We use MootBot to record the meetings.
The purpose of the meetings is to coordinate Launchpad code reviews, and particularly to ensure that emerging issues with the review process are addressed - such as getting people to take on tough reviews, keeping the latency down, etc.. Blockage in reviews leads to blockage in Launchpad code landings.
The next Launchpad review team meeting will be held at this time:
AMEU Wednesday 20-Jan-2010 1500 UTC - 1545 UTC
AsiaPac Wednesday 20-Jan-2010 2100 UTC - 2145 UTC
You can add new items to the list of proposed items. If they don't make it onto this meetings agenda, they'll most likely get onto the next meeting's agenda instead.
Agenda
- Roll call
- Action items
- Peanut gallery (anything not on the agenda)
Apologies
Please include the date for which you will be unavailable.
yourname, date
Outstanding Actions
- intellectronica to draft guidelines for drive-by cleanups
- Maris to bring up cross-team reviews in the lazr-js task force meeting and report back.
- Gavin to start discussion on the ML about doctest size, refactoring, moving corner cases to unittests, etc
- Gary to do timing tests for try/except, examine current usage of check_permission, and we'll discuss again next week.
- Curtis to land a import cleanup branch and then reviewers will enforce zero tolerance for introducing new issues.
Notes
Proposed items
- topic [yourname]
Rejected items
